Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3577)

Unified Diff: chrome/browser/net/predictor.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: less comments more ownership Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/metrics/plugin_metrics_provider.cc ('k') | chrome/browser/net/referrer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/net/predictor.cc
diff --git a/chrome/browser/net/predictor.cc b/chrome/browser/net/predictor.cc
index 7c9ecea088c0d3dc3c0116ad0de0982c7175f1db..e375df45c21697a1cf163a67ddbea5c0ee2f9b55 100644
--- a/chrome/browser/net/predictor.cc
+++ b/chrome/browser/net/predictor.cc
@@ -8,6 +8,7 @@
#include <cmath>
#include <set>
#include <sstream>
+#include <utility>
#include "base/bind.h"
#include "base/compiler_specific.h"
@@ -595,11 +596,11 @@ void Predictor::SerializeReferrers(base::ListValue* referral_list) {
base::Value* subresource_list(it->second.Serialize());
// Create a list for each referer.
- base::ListValue* motivator(new base::ListValue);
+ std::unique_ptr<base::ListValue> motivator(new base::ListValue);
motivator->AppendString(it->first.spec());
motivator->Append(subresource_list);
- referral_list->Append(motivator);
+ referral_list->Append(std::move(motivator));
}
}
« no previous file with comments | « chrome/browser/metrics/plugin_metrics_provider.cc ('k') | chrome/browser/net/referrer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698