chrome/browser/extensions/api/top_sites/top_sites_api.cc - Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/top_sites/top_sites_api.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: less comments more ownership Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/tabs/tabs_event_router.cc ('k') | chrome/browser/extensions/api/web_navigation/web_navigation_api_helpers.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/top_sites/top_sites_api.cc

diff --git a/chrome/browser/extensions/api/top_sites/top_sites_api.cc b/chrome/browser/extensions/api/top_sites/top_sites_api.cc

index 9446b048a3a0675c37b040d04d875b38efbe115c..0df2d28cbc4b75d2897afe383737fe3ae6e7b30c 100644

--- a/chrome/browser/extensions/api/top_sites/top_sites_api.cc

+++ b/chrome/browser/extensions/api/top_sites/top_sites_api.cc

@@ -6,6 +6,7 @@

#include <stddef.h>

+#include <memory>

#include <utility>

#include "base/bind.h"

@@ -40,13 +41,14 @@ void TopSitesGetFunction::OnMostVisitedURLsAvailable(

for (size_t i = 0; i < data.size(); i++) {

const history::MostVisitedURL& url = data[i];

if (!url.url.is_empty()) {

- base::DictionaryValue* page_value = new base::DictionaryValue();

+ std::unique_ptr<base::DictionaryValue> page_value(

+ new base::DictionaryValue());

page_value->SetString("url", url.url.spec());

if (url.title.empty())

page_value->SetString("title", url.url.spec());

else

page_value->SetString("title", url.title);

- pages_value->Append(page_value);

+ pages_value->Append(std::move(page_value));

}