Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5001)

Unified Diff: chrome/browser/plugins/plugin_prefs.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: less comments more ownership Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/net/referrer.cc ('k') | chrome/browser/prerender/prerender_history.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/plugins/plugin_prefs.cc
diff --git a/chrome/browser/plugins/plugin_prefs.cc b/chrome/browser/plugins/plugin_prefs.cc
index 6995dc913a155362c4ba740a06728a27c3babdb7..66ae98016bb07de481bbd4f8e6a97dd4195974bb 100644
--- a/chrome/browser/plugins/plugin_prefs.cc
+++ b/chrome/browser/plugins/plugin_prefs.cc
@@ -8,6 +8,7 @@
#include <memory>
#include <string>
+#include <utility>
#include "base/bind.h"
#include "base/command_line.h"
@@ -481,14 +482,14 @@ void PluginPrefs::OnUpdatePreferences(
// Add the plugin files.
std::set<base::string16> group_names;
for (size_t i = 0; i < plugins.size(); ++i) {
- base::DictionaryValue* summary = new base::DictionaryValue();
+ std::unique_ptr<base::DictionaryValue> summary(new base::DictionaryValue());
summary->SetString("path", plugins[i].path.value());
summary->SetString("name", plugins[i].name);
summary->SetString("version", plugins[i].version);
bool enabled = true;
plugin_state_.Get(plugins[i].path, &enabled);
summary->SetBoolean("enabled", enabled);
- plugins_list->Append(summary);
+ plugins_list->Append(std::move(summary));
std::unique_ptr<PluginMetadata> plugin_metadata(
finder->GetPluginMetadata(plugins[i]));
@@ -499,7 +500,7 @@ void PluginPrefs::OnUpdatePreferences(
// Add the plugin groups.
for (std::set<base::string16>::const_iterator it = group_names.begin();
it != group_names.end(); ++it) {
- base::DictionaryValue* summary = new base::DictionaryValue();
+ std::unique_ptr<base::DictionaryValue> summary(new base::DictionaryValue());
summary->SetString("name", *it);
bool enabled = true;
std::map<base::string16, bool>::iterator gstate_it =
@@ -507,7 +508,7 @@ void PluginPrefs::OnUpdatePreferences(
if (gstate_it != plugin_group_state_.end())
enabled = gstate_it->second;
summary->SetBoolean("enabled", enabled);
- plugins_list->Append(summary);
+ plugins_list->Append(std::move(summary));
}
}
« no previous file with comments | « chrome/browser/net/referrer.cc ('k') | chrome/browser/prerender/prerender_history.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698