Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: tools/json_schema_compiler/test/callbacks_unittest.cc

Issue 2058233002: Rewrite simple uses of base::ListValue::Append() taking a raw pointer var. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: less comments more ownership Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/json_schema_compiler/test/callbacks_unittest.cc
diff --git a/tools/json_schema_compiler/test/callbacks_unittest.cc b/tools/json_schema_compiler/test/callbacks_unittest.cc
index 76cbf963ce0bea40a0a74b49330c0a20d1e80fe1..b6c07e02bc01006518122f74a555c98e1edd7e85 100644
--- a/tools/json_schema_compiler/test/callbacks_unittest.cc
+++ b/tools/json_schema_compiler/test/callbacks_unittest.cc
@@ -4,6 +4,9 @@
#include "tools/json_schema_compiler/test/callbacks.h"
+#include <memory>
+#include <utility>
+
#include "testing/gtest/include/gtest/gtest.h"
using namespace test::api::callbacks;
@@ -14,10 +17,11 @@ TEST(JsonSchemaCompilerCallbacksTest, ReturnsObjectResultCreate) {
std::unique_ptr<base::ListValue> results =
ReturnsObject::Results::Create(some_object);
- base::DictionaryValue* expected_dict = new base::DictionaryValue();
+ std::unique_ptr<base::DictionaryValue> expected_dict(
+ new base::DictionaryValue());
expected_dict->SetString("state", "foo");
base::ListValue expected;
- expected.Append(expected_dict);
+ expected.Append(std::move(expected_dict));
EXPECT_TRUE(results->Equals(&expected));
}
@@ -27,10 +31,11 @@ TEST(JsonSchemaCompilerCallbacksTest, ReturnsMultipleResultCreate) {
std::unique_ptr<base::ListValue> results =
ReturnsMultiple::Results::Create(5, some_object);
- base::DictionaryValue* expected_dict = new base::DictionaryValue();
+ std::unique_ptr<base::DictionaryValue> expected_dict(
+ new base::DictionaryValue());
expected_dict->SetString("state", "foo");
base::ListValue expected;
expected.AppendInteger(5);
- expected.Append(expected_dict);
+ expected.Append(std::move(expected_dict));
EXPECT_TRUE(results->Equals(&expected));
}
« no previous file with comments | « tools/json_schema_compiler/test/arrays_unittest.cc ('k') | tools/json_schema_compiler/test/idl_schemas_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698