Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

This is just a mechanical rename and reformat. The rename is good because:

 1) WebUI::CallJavascriptFunctionUnsafe is indeed unsafe and the caller
    is responsible for knowing when it is safe to call.

 2) WebUIMessageHandler::CallJavascriptFunction is the new preferred way.

 3) The change makes the above two points clear to coders not to use
    WebUI directly unless they know what they are doing.

In the future, WebUI::CallJavascriptFunctionUnsafe may become a private
member with a few friend classes.

See design doc for more details:
https://docs.google.com/a/chromium.org/document/d/1z1diKvwgMmn4YFzlW1kss0yHmo8yy68TN_FUhUzRz7Q/edit?usp=sharing

BUG=602523
Committed: https://crrev.com/88035384762c47b218d81fbe9cdda249efda28d9
Cr-Commit-Position: refs/heads/master@{#398070}

[tommycli, 2016-05-19 19:40:57]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-19 19:41:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1995113002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1995113002/1

[commit-bot: I haz the power, 2016-05-19 19:52:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 19:52:53]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[tommycli, 2016-05-19 20:26:50]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-19 20:28:04]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1995113002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1995113002/20001

[commit-bot: I haz the power, 2016-05-19 20:37:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 20:37:39]

Dry run: Try jobs failed on following builders:
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[tommycli, 2016-05-19 20:46:03]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-19 20:46:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1995113002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1995113002/40001

[commit-bot: I haz the power, 2016-05-19 21:00:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 21:00:19]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_clang on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[tommycli, 2016-05-19 21:01:21]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-19 21:02:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1995113002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1995113002/60001

[commit-bot: I haz the power, 2016-05-19 21:17:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 21:17:17]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[tommycli, 2016-05-19 21:39:13]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-19 21:40:00]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1995113002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1995113002/80001

[commit-bot: I haz the power, 2016-05-19 22:01:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-19 22:01:07]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[tommycli, 2016-05-19 23:44:36]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-19 23:45:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1995113002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1995113002/100001

[commit-bot: I haz the power, 2016-05-20 03:12:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-20 03:12:48]

Dry run: This issue passed the CQ dry run.

[tommycli, 2016-05-20 16:22:00]

tommycli@chromium.org changed reviewers:
+ creis@chromium.org, dbeam@chromium.org

[tommycli, 2016-05-20 16:22:02]

creis/dbeam: PTAL for initial review.

nasko is OOO, so he's only CCed.

If this looks good to you guys, I'll send it to the general src/ OWNERs.

[mmenke, 2016-05-20 16:47:57]

Description was changed from

==========
Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

This is just a mechanical rename and reformat. The rename is good because:

 1) WebUI::CallJavascriptFunctionUnsafe is indeed unsafe and the caller
    is responsible for knowing when it is safe to call.

 2) WebUIMessageHandler::CallJavascriptFunction is the new preferred way.

 3) The change makes the above two points clear to coders not to use
    WebUI directly unless they know what they are doing.

In the future, WebUI::CallJavascriptFunctionUnsafe may become a private
member with a few friend classes.

See design doc for more details:
https://docs.google.com/a/chromium.org/document/d/1z1diKvwgMmn4YFzlW1kss0yHmo...

BUG=602523
==========

to

==========
Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

This is just a mechanical rename and reformat. The rename is good because:

 1) WebUI::CallJavascriptFunctionUnsafe is indeed unsafe and the caller
    is responsible for knowing when it is safe to call.

 2) WebUIMessageHandler::CallJavascriptFunction is the new preferred way.

 3) The change makes the above two points clear to coders not to use
    WebUI directly unless they know what they are doing.

In the future, WebUI::CallJavascriptFunctionUnsafe may become a private
member with a few friend classes.

See design doc for more details:
https://docs.google.com/a/chromium.org/document/d/1z1diKvwgMmn4YFzlW1kss0yHmo...

BUG=602523
==========

[Charlie Reis, 2016-05-23 20:26:00]

Thanks for making progress on this deprecation!  (It's astonishing how many
unsafe calls there are.)  LGTM with the changes below.

https://codereview.chromium.org/1995113002/diff/100001/content/public/browser...
File content/public/browser/web_ui.h (right):

https://codereview.chromium.org/1995113002/diff/100001/content/public/browser...
content/public/browser/web_ui.h:98: // to call
WebUIMessageHandler::CallJavascriptFunctionUnsafe, as that has
This should still be CallJavascriptFunction.

https://codereview.chromium.org/1995113002/diff/100001/content/public/browser...
File content/public/browser/web_ui_message_handler.h (right):

https://codereview.chromium.org/1995113002/diff/100001/content/public/browser...
content/public/browser/web_ui_message_handler.h:91:
web_ui()->CallJavascriptFunctionUnsafe(function_name, values...);
Maybe put a comment here saying that the check above makes this call safe, just
to close the loop?

[Dan Beam, 2016-05-24 01:56:05]

lgtm, agree with creis@' comments

[tommycli, 2016-06-03 17:52:45]

creis/dbeam: thanks all!

https://codereview.chromium.org/1995113002/diff/100001/content/public/browser...
File content/public/browser/web_ui.h (right):

https://codereview.chromium.org/1995113002/diff/100001/content/public/browser...
content/public/browser/web_ui.h:98: // to call
WebUIMessageHandler::CallJavascriptFunctionUnsafe, as that has
On 2016/05/23 20:26:00, Charlie Reis wrote:
> This should still be CallJavascriptFunction.

Done.

https://codereview.chromium.org/1995113002/diff/100001/content/public/browser...
File content/public/browser/web_ui_message_handler.h (right):

https://codereview.chromium.org/1995113002/diff/100001/content/public/browser...
content/public/browser/web_ui_message_handler.h:91:
web_ui()->CallJavascriptFunctionUnsafe(function_name, values...);
On 2016/05/23 20:26:00, Charlie Reis wrote:
> Maybe put a comment here saying that the check above makes this call safe,
just
> to close the loop?

Done.

[tommycli, 2016-06-03 18:32:12]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-06-03 18:32:16]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org,
dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1995113002/#ps120001
(title: " ")

[commit-bot: I haz the power, 2016-06-03 18:32:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1995113002/120001

[commit-bot: I haz the power, 2016-06-03 18:44:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 18:44:07]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tommycli, 2016-06-03 18:54:32]

tommycli@chromium.org changed reviewers:
+ cpu@chromium.org

[tommycli, 2016-06-03 18:54:34]

cpu: PTAL. Need OWNER stamp for src/. Just a mechanical function rename.

Thanks,

Tommy

[cpu_(ooo_6.6-7.5), 2016-06-03 23:39:24]

lgtm

[tommycli, 2016-06-03 23:59:50]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2016-06-04 00:00:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1995113002/120001

[commit-bot: I haz the power, 2016-06-04 00:11:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-04 00:11:18]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tommycli, 2016-06-06 16:22:16]

The CQ bit was checked by tommycli@chromium.org

[tommycli, 2016-06-06 16:22:17]

The patchset sent to the CQ was uploaded after l-g-t-m from cpu@chromium.org,
creis@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/1995113002/#ps140001
(title: " ")

[commit-bot: I haz the power, 2016-06-06 16:22:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1995113002/140001

[commit-bot: I haz the power, 2016-06-06 18:26:31]

Description was changed from

==========
Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

This is just a mechanical rename and reformat. The rename is good because:

 1) WebUI::CallJavascriptFunctionUnsafe is indeed unsafe and the caller
    is responsible for knowing when it is safe to call.

 2) WebUIMessageHandler::CallJavascriptFunction is the new preferred way.

 3) The change makes the above two points clear to coders not to use
    WebUI directly unless they know what they are doing.

In the future, WebUI::CallJavascriptFunctionUnsafe may become a private
member with a few friend classes.

See design doc for more details:
https://docs.google.com/a/chromium.org/document/d/1z1diKvwgMmn4YFzlW1kss0yHmo...

BUG=602523
==========

to

==========
Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

This is just a mechanical rename and reformat. The rename is good because:

 1) WebUI::CallJavascriptFunctionUnsafe is indeed unsafe and the caller
    is responsible for knowing when it is safe to call.

 2) WebUIMessageHandler::CallJavascriptFunction is the new preferred way.

 3) The change makes the above two points clear to coders not to use
    WebUI directly unless they know what they are doing.

In the future, WebUI::CallJavascriptFunctionUnsafe may become a private
member with a few friend classes.

See design doc for more details:
https://docs.google.com/a/chromium.org/document/d/1z1diKvwgMmn4YFzlW1kss0yHmo...

BUG=602523
==========

[commit-bot: I haz the power, 2016-06-06 18:26:35]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-06-06 18:28:20]

Description was changed from

==========
Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

This is just a mechanical rename and reformat. The rename is good because:

 1) WebUI::CallJavascriptFunctionUnsafe is indeed unsafe and the caller
    is responsible for knowing when it is safe to call.

 2) WebUIMessageHandler::CallJavascriptFunction is the new preferred way.

 3) The change makes the above two points clear to coders not to use
    WebUI directly unless they know what they are doing.

In the future, WebUI::CallJavascriptFunctionUnsafe may become a private
member with a few friend classes.

See design doc for more details:
https://docs.google.com/a/chromium.org/document/d/1z1diKvwgMmn4YFzlW1kss0yHmo...

BUG=602523
==========

to

==========
Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

This is just a mechanical rename and reformat. The rename is good because:

 1) WebUI::CallJavascriptFunctionUnsafe is indeed unsafe and the caller
    is responsible for knowing when it is safe to call.

 2) WebUIMessageHandler::CallJavascriptFunction is the new preferred way.

 3) The change makes the above two points clear to coders not to use
    WebUI directly unless they know what they are doing.

In the future, WebUI::CallJavascriptFunctionUnsafe may become a private
member with a few friend classes.

See design doc for more details:
https://docs.google.com/a/chromium.org/document/d/1z1diKvwgMmn4YFzlW1kss0yHmo...

BUG=602523

Committed: https://crrev.com/88035384762c47b218d81fbe9cdda249efda28d9
Cr-Commit-Position: refs/heads/master@{#398070}
==========

[commit-bot: I haz the power, 2016-06-06 18:28:24]

Patchset 8 (id:??) landed as
https://crrev.com/88035384762c47b218d81fbe9cdda249efda28d9
Cr-Commit-Position: refs/heads/master@{#398070}