Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5138)

Unified Diff: chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc
diff --git a/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc b/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc
index 512d920bed70134989f76e6a4349e0decf595319..30e236ea8927b16f9890b61d820978add1b319d0 100644
--- a/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc
+++ b/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc
@@ -70,7 +70,7 @@ void PasswordManagerInternalsUI::DidStopLoading() {
Profile::FromWebUI(web_ui()));
// No service means the WebUI is displayed in Incognito.
base::FundamentalValue is_incognito(!service);
- web_ui()->CallJavascriptFunction("notifyAboutIncognito", is_incognito);
+ web_ui()->CallJavascriptFunctionUnsafe("notifyAboutIncognito", is_incognito);
if (service) {
registered_with_logging_service_ = true;
@@ -99,8 +99,8 @@ void PasswordManagerInternalsUI::LogSavePasswordProgress(
std::string no_quotes(text);
std::replace(no_quotes.begin(), no_quotes.end(), '"', ' ');
base::StringValue text_string_value(net::EscapeForHTML(no_quotes));
- web_ui()->CallJavascriptFunction("addSavePasswordProgressLog",
- text_string_value);
+ web_ui()->CallJavascriptFunctionUnsafe("addSavePasswordProgressLog",
+ text_string_value);
}
void PasswordManagerInternalsUI::UnregisterFromLoggingServiceIfNecessary() {
« no previous file with comments | « chrome/browser/ui/webui/options/sync_setup_handler.cc ('k') | chrome/browser/ui/webui/policy_material_design_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698