chrome/browser/ui/webui/options/chromeos/power_handler.cc - Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/power_handler.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/pointer_handler.cc ('k') | chrome/browser/ui/webui/options/chromeos/proxy_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/power_handler.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/power_handler.cc b/chrome/browser/ui/webui/options/chromeos/power_handler.cc

index 5883309d6c469751fc7f9c19bc8a7f097ae7e683..97c0f963ab94056fdec22a5c7679e2aeaabda6e2 100644

--- a/chrome/browser/ui/webui/options/chromeos/power_handler.cc

+++ b/chrome/browser/ui/webui/options/chromeos/power_handler.cc

@@ -80,7 +80,7 @@ void PowerHandler::RegisterMessages() {

}

void PowerHandler::OnPowerStatusChanged() {

- web_ui()->CallJavascriptFunction(

+ web_ui()->CallJavascriptFunctionUnsafe(

"options.PowerOverlay.setBatteryStatusText",

base::StringValue(GetStatusValue()));

UpdatePowerSources();

@@ -158,9 +158,8 @@ void PowerHandler::UpdatePowerSources() {

sources_list.Append(dict.release());

}

- web_ui()->CallJavascriptFunction(

- "options.PowerOverlay.setPowerSources",

- sources_list,

+ web_ui()->CallJavascriptFunctionUnsafe(

+ "options.PowerOverlay.setPowerSources", sources_list,

base::StringValue(status->GetCurrentPowerSourceID()),

base::FundamentalValue(status->IsUsbChargerConnected()),

base::FundamentalValue(status->IsBatteryTimeBeingCalculated()));