chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc - Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/chromeos/first_run/first_run_handler.cc ('k') | chrome/browser/ui/webui/chromeos/login/base_screen_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc

diff --git a/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc b/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc

index ba5bbaa9b8a772f2f089a850cc9d263d4e958b57..37447688d2fda4c20964c094a1410824e70fd7f9 100644

--- a/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc

+++ b/chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc

@@ -374,7 +374,7 @@ void KeyboardOverlayHandler::GetInputMethodId(const base::ListValue* args) {

const chromeos::input_method::InputMethodDescriptor& descriptor =

manager->GetActiveIMEState()->GetCurrentInputMethod();

base::StringValue param(descriptor.id());

- web_ui()->CallJavascriptFunction("initKeyboardOverlayId", param);

+ web_ui()->CallJavascriptFunctionUnsafe("initKeyboardOverlayId", param);

}

void KeyboardOverlayHandler::GetLabelMap(const base::ListValue* args) {

@@ -397,7 +397,7 @@ void KeyboardOverlayHandler::GetLabelMap(const base::ListValue* args) {

dict.SetString(ModifierKeyToLabel(i->first), ModifierKeyToLabel(i->second));

}

- web_ui()->CallJavascriptFunction("initIdentifierMap", dict);

+ web_ui()->CallJavascriptFunctionUnsafe("initIdentifierMap", dict);

}

void KeyboardOverlayHandler::OpenLearnMorePage(const base::ListValue* args) {