chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc - Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/net_internals/net_internals_ui.cc ('k') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

diff --git a/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc b/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

index e17105350e0ae80f16c9224e58587db822c6e250..1c3e48b997d47b50a611e2ef6ba960890fb926d4 100644

--- a/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

+++ b/chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc

@@ -189,7 +189,7 @@ void NetInternalsTest::MessageHandler::RegisterMessages() {

void NetInternalsTest::MessageHandler::RunJavascriptCallback(

base::Value* value) {

- web_ui()->CallJavascriptFunction("NetInternalsTest.callback", *value);

+ web_ui()->CallJavascriptFunctionUnsafe("NetInternalsTest.callback", *value);

}

void NetInternalsTest::MessageHandler::GetTestServerURL(

@@ -264,7 +264,7 @@ void NetInternalsTest::MessageHandler::CreateIncognitoBrowser(

// Tell the test harness that creation is complete.

base::StringValue command_value("onIncognitoBrowserCreatedForTest");

- web_ui()->CallJavascriptFunction("g_browser.receive", command_value);

+ web_ui()->CallJavascriptFunctionUnsafe("g_browser.receive", command_value);

}

void NetInternalsTest::MessageHandler::CloseIncognitoBrowser(

« no previous file with comments | « chrome/browser/ui/webui/net_internals/net_internals_ui.cc ('k') | chrome/browser/ui/webui/ntp/app_launcher_handler.cc » ('j') | no next file with comments »