Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Unified Diff: content/browser/appcache/appcache_internals_ui.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/accessibility/accessibility_ui.cc ('k') | content/browser/gpu/gpu_internals_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/appcache/appcache_internals_ui.cc
diff --git a/content/browser/appcache/appcache_internals_ui.cc b/content/browser/appcache/appcache_internals_ui.cc
index 10f316e61354fa2aeae3c8a1032041bc88214ef1..0c83ce031fc8bc501af8a110584f021b6f234849 100644
--- a/content/browser/appcache/appcache_internals_ui.cc
+++ b/content/browser/appcache/appcache_internals_ui.cc
@@ -419,7 +419,7 @@ void AppCacheInternalsUI::OnAllAppCacheInfoReady(
std::string incognito_path_prefix;
if (browser_context()->IsOffTheRecord())
incognito_path_prefix = "Incognito ";
- web_ui()->CallJavascriptFunction(
+ web_ui()->CallJavascriptFunctionUnsafe(
kFunctionOnAllAppCacheInfoReady,
base::StringValue(incognito_path_prefix + partition_path.AsUTF8Unsafe()),
*GetListValueFromAppCacheInfoCollection(collection.get()));
@@ -429,7 +429,7 @@ void AppCacheInternalsUI::OnAppCacheInfoDeleted(
const base::FilePath& partition_path,
const std::string& manifest_url,
bool deleted) {
- web_ui()->CallJavascriptFunction(
+ web_ui()->CallJavascriptFunctionUnsafe(
kFunctionOnAppCacheInfoDeleted,
base::StringValue(partition_path.AsUTF8Unsafe()),
base::StringValue(manifest_url), base::FundamentalValue(deleted));
@@ -440,12 +440,12 @@ void AppCacheInternalsUI::OnAppCacheDetailsReady(
const std::string& manifest_url,
std::unique_ptr<AppCacheResourceInfoVector> resource_info_vector) {
if (resource_info_vector) {
- web_ui()->CallJavascriptFunction(
+ web_ui()->CallJavascriptFunctionUnsafe(
kFunctionOnAppCacheDetailsReady, base::StringValue(manifest_url),
base::StringValue(partition_path.AsUTF8Unsafe()),
*GetListValueForAppCacheResourceInfoVector(resource_info_vector.get()));
} else {
- web_ui()->CallJavascriptFunction(
+ web_ui()->CallJavascriptFunctionUnsafe(
kFunctionOnAppCacheDetailsReady, base::StringValue(manifest_url),
base::StringValue(partition_path.AsUTF8Unsafe()));
}
@@ -483,7 +483,7 @@ void AppCacheInternalsUI::OnFileDetailsReady(
if (data_length < response_info->response_data_size())
hex_dump.append("\nNote: data is truncated...");
hex_dump.append("</pre>");
- web_ui()->CallJavascriptFunction(
+ web_ui()->CallJavascriptFunctionUnsafe(
kFunctionOnFileDetailsReady,
*GetDictionaryValueForResponseEnquiry(response_enquiry),
base::StringValue(headers), base::StringValue(hex_dump));
@@ -492,7 +492,7 @@ void AppCacheInternalsUI::OnFileDetailsReady(
void AppCacheInternalsUI::OnFileDetailsFailed(
const Proxy::ResponseEnquiry& response_enquiry,
int net_result_code) {
- web_ui()->CallJavascriptFunction(
+ web_ui()->CallJavascriptFunctionUnsafe(
kFunctionOnFileDetailsFailed,
*GetDictionaryValueForResponseEnquiry(response_enquiry),
base::FundamentalValue(net_result_code));
« no previous file with comments | « content/browser/accessibility/accessibility_ui.cc ('k') | content/browser/gpu/gpu_internals_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698