chrome/browser/ui/webui/options/supervised_user_create_confirm_handler.cc - Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/supervised_user_create_confirm_handler.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/startup_pages_handler.cc ('k') | chrome/browser/ui/webui/options/supervised_user_import_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/supervised_user_create_confirm_handler.cc

diff --git a/chrome/browser/ui/webui/options/supervised_user_create_confirm_handler.cc b/chrome/browser/ui/webui/options/supervised_user_create_confirm_handler.cc

index 0d418822ed5aae0e4c7a464141f9ac5b08e170ab..d0f803701e5a8a9c7199dbaf0a0bdf469eaef808 100644

--- a/chrome/browser/ui/webui/options/supervised_user_create_confirm_handler.cc

+++ b/chrome/browser/ui/webui/options/supervised_user_create_confirm_handler.cc

@@ -56,7 +56,7 @@ class SupervisedUserCreateConfirmHandler::ProfileUpdateObserver

const base::string16& profile_name) override {

std::unique_ptr<base::StringValue> profile_path_value(

base::CreateFilePathValue(profile_path));

- create_confirm_handler_->web_ui()->CallJavascriptFunction(

+ create_confirm_handler_->web_ui()->CallJavascriptFunctionUnsafe(

"SupervisedUserCreateConfirmOverlay.onDeletedProfile",

*profile_path_value);

}

@@ -70,10 +70,9 @@ class SupervisedUserCreateConfirmHandler::ProfileUpdateObserver

base::string16 new_profile_name = entry->GetName();

std::unique_ptr<base::StringValue> profile_path_value(

base::CreateFilePathValue(profile_path));

- create_confirm_handler_->web_ui()->CallJavascriptFunction(

+ create_confirm_handler_->web_ui()->CallJavascriptFunctionUnsafe(

"SupervisedUserCreateConfirmOverlay.onUpdatedProfileName",

- *profile_path_value,

- base::StringValue(new_profile_name));

+ *profile_path_value, base::StringValue(new_profile_name));

}

// Weak.