Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5549)

Unified Diff: chrome/browser/ui/webui/options/sync_setup_handler.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/sync_setup_handler.cc
diff --git a/chrome/browser/ui/webui/options/sync_setup_handler.cc b/chrome/browser/ui/webui/options/sync_setup_handler.cc
index 716aacec8f5559d33164639465dbf948b9d89930..f48402af8136ceaf6890541eca9ea0a8b98d64ea 100644
--- a/chrome/browser/ui/webui/options/sync_setup_handler.cc
+++ b/chrome/browser/ui/webui/options/sync_setup_handler.cc
@@ -285,8 +285,8 @@ void SyncSetupHandler::GetStaticLocalizedValues(
void SyncSetupHandler::ConfigureSyncDone() {
base::StringValue page("done");
- web_ui()->CallJavascriptFunction(
- "SyncSetupOverlay.showSyncSetupPage", page);
+ web_ui()->CallJavascriptFunctionUnsafe("SyncSetupOverlay.showSyncSetupPage",
+ page);
// Suppress the sign in promo once the user starts sync. This way the user
// doesn't see the sign in promo even if they sign out later on.
@@ -436,8 +436,8 @@ void SyncSetupHandler::DisplaySpinner() {
base::TimeDelta::FromSeconds(kTimeoutSec),
this, &SyncSetupHandler::DisplayTimeout);
- web_ui()->CallJavascriptFunction(
- "SyncSetupOverlay.showSyncSetupPage", page, args);
+ web_ui()->CallJavascriptFunctionUnsafe("SyncSetupOverlay.showSyncSetupPage",
+ page, args);
}
// TODO(kochi): Handle error conditions other than timeout.
@@ -451,8 +451,8 @@ void SyncSetupHandler::DisplayTimeout() {
base::StringValue page("timeout");
base::DictionaryValue args;
- web_ui()->CallJavascriptFunction(
- "SyncSetupOverlay.showSyncSetupPage", page, args);
+ web_ui()->CallJavascriptFunctionUnsafe("SyncSetupOverlay.showSyncSetupPage",
+ page, args);
}
void SyncSetupHandler::OnDidClosePage(const base::ListValue* args) {
@@ -794,8 +794,8 @@ void SyncSetupHandler::FocusUI() {
void SyncSetupHandler::CloseUI() {
CloseSyncSetup();
base::StringValue page("done");
- web_ui()->CallJavascriptFunction(
- "SyncSetupOverlay.showSyncSetupPage", page);
+ web_ui()->CallJavascriptFunctionUnsafe("SyncSetupOverlay.showSyncSetupPage",
+ page);
}
bool SyncSetupHandler::IsExistingWizardPresent() {
@@ -938,8 +938,8 @@ void SyncSetupHandler::DisplayConfigureSync(bool passphrase_failed) {
}
base::StringValue page("configure");
- web_ui()->CallJavascriptFunction(
- "SyncSetupOverlay.showSyncSetupPage", page, args);
+ web_ui()->CallJavascriptFunctionUnsafe("SyncSetupOverlay.showSyncSetupPage",
+ page, args);
// Make sure the tab used for the Gaia sign in does not cover the settings
// tab.

Powered by Google App Engine
This is Rietveld 408576698