chrome/browser/ui/webui/signin/sync_confirmation_handler.cc - Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/sync_confirmation_handler.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc ('k') | chrome/browser/ui/webui/signin/user_manager_screen_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/signin/sync_confirmation_handler.cc

diff --git a/chrome/browser/ui/webui/signin/sync_confirmation_handler.cc b/chrome/browser/ui/webui/signin/sync_confirmation_handler.cc

index 5c2ab867fc968d07c23cc1ac0587b05ff937e30a..b538951d47f26e5dc6aeec41d7fdde8ebaf10077 100644

--- a/chrome/browser/ui/webui/signin/sync_confirmation_handler.cc

+++ b/chrome/browser/ui/webui/signin/sync_confirmation_handler.cc

@@ -79,8 +79,8 @@ void SyncConfirmationHandler::SetUserImageURL(const std::string& picture_url) {

kProfileImageSize,

&url)) {

base::StringValue picture_url_value(url.spec());

- web_ui()->CallJavascriptFunction(

- "sync.confirmation.setUserImageURL", picture_url_value);

+ web_ui()->CallJavascriptFunctionUnsafe("sync.confirmation.setUserImageURL",

+ picture_url_value);

}

@@ -138,5 +138,5 @@ void SyncConfirmationHandler::HandleInitializedWithSize(

// TODO(anthonyvd): Figure out why this is needed on Mac and not other

// platforms and if there's a way to start unfocused while avoiding this

// workaround.

- web_ui()->CallJavascriptFunction("sync.confirmation.clearFocus");

+ web_ui()->CallJavascriptFunctionUnsafe("sync.confirmation.clearFocus");

}