Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: chrome/browser/ui/webui/options/password_manager_handler.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/password_manager_handler.cc
diff --git a/chrome/browser/ui/webui/options/password_manager_handler.cc b/chrome/browser/ui/webui/options/password_manager_handler.cc
index 97e1f611947c8509e01e21423beff5889b95394f..c15af4656c18f012437ea3145e1b865ca63c70a0 100644
--- a/chrome/browser/ui/webui/options/password_manager_handler.cc
+++ b/chrome/browser/ui/webui/options/password_manager_handler.cc
@@ -211,7 +211,8 @@ void PasswordManagerHandler::InitializeHandler() {
void PasswordManagerHandler::InitializePage() {
if (base::FeatureList::IsEnabled(
password_manager::features::kPasswordImportExport)) {
- web_ui()->CallJavascriptFunction("PasswordManager.showImportExportButton");
+ web_ui()->CallJavascriptFunctionUnsafe(
+ "PasswordManager.showImportExportButton");
}
}
@@ -250,7 +251,7 @@ void PasswordManagerHandler::ShowPassword(
const std::string& username,
const base::string16& password_value) {
// Call back the front end to reveal the password.
- web_ui()->CallJavascriptFunction(
+ web_ui()->CallJavascriptFunctionUnsafe(
"PasswordManager.showPassword",
base::FundamentalValue(static_cast<int>(index)),
base::StringValue(password_value));
@@ -285,8 +286,8 @@ void PasswordManagerHandler::SetPasswordList(
entries.Append(entry.release());
}
- web_ui()->CallJavascriptFunction("PasswordManager.setSavedPasswordsList",
- entries);
+ web_ui()->CallJavascriptFunctionUnsafe(
+ "PasswordManager.setSavedPasswordsList", entries);
}
void PasswordManagerHandler::SetPasswordExceptionList(
@@ -299,8 +300,8 @@ void PasswordManagerHandler::SetPasswordExceptionList(
entries.Append(entry.release());
}
- web_ui()->CallJavascriptFunction("PasswordManager.setPasswordExceptionsList",
- entries);
+ web_ui()->CallJavascriptFunctionUnsafe(
+ "PasswordManager.setPasswordExceptionsList", entries);
}
void PasswordManagerHandler::FileSelected(const base::FilePath& path,
« no previous file with comments | « chrome/browser/ui/webui/options/options_ui.cc ('k') | chrome/browser/ui/webui/options/reset_profile_settings_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698