chrome/browser/ui/app_list/start_page_service.cc - Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/app_list/start_page_service.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/printing/print_preview_pdf_generated_browsertest.cc ('k') | chrome/browser/ui/signin_view_controller_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/app_list/start_page_service.cc

diff --git a/chrome/browser/ui/app_list/start_page_service.cc b/chrome/browser/ui/app_list/start_page_service.cc

index 89298fe4988eb8a12e7094f3c3da32dec68097bb..dad29aadc5ba27e720a3a07e387a376911d918fd 100644

--- a/chrome/browser/ui/app_list/start_page_service.cc

+++ b/chrome/browser/ui/app_list/start_page_service.cc

@@ -408,7 +408,7 @@ void StartPageService::AppListShown() {

} else if (contents_->IsCrashed()) {

LoadStartPageURL();

} else if (contents_->GetWebUI()) {

- contents_->GetWebUI()->CallJavascriptFunction(

+ contents_->GetWebUI()->CallJavascriptFunctionUnsafe(

"appList.startPage.onAppListShown");

}

@@ -690,7 +690,7 @@ void StartPageService::OnURLFetchComplete(const net::URLFetcher* source) {

recheck_delay = base::TimeDelta::FromMilliseconds(kMaximumRecheckDelayMs);

if (contents_ && contents_->GetWebUI()) {

- contents_->GetWebUI()->CallJavascriptFunction(

+ contents_->GetWebUI()->CallJavascriptFunctionUnsafe(

"appList.startPage.onAppListDoodleUpdated", *doodle_json,

base::StringValue(

UIThreadSearchTermsData(profile_).GoogleBaseURLValue()));