chrome/browser/ui/webui/options/language_dictionary_overlay_handler.cc - Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/language_dictionary_overlay_handler.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/import_data_handler.cc ('k') | chrome/browser/ui/webui/options/language_options_handler_common.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/language_dictionary_overlay_handler.cc

diff --git a/chrome/browser/ui/webui/options/language_dictionary_overlay_handler.cc b/chrome/browser/ui/webui/options/language_dictionary_overlay_handler.cc

index 4ce1839def83fcf5b0aed8b655c9af2a46c72d6e..247383effce417cae3fc6aadad75c7c0cf5cc4a0 100644

--- a/chrome/browser/ui/webui/options/language_dictionary_overlay_handler.cc

+++ b/chrome/browser/ui/webui/options/language_dictionary_overlay_handler.cc

@@ -84,8 +84,8 @@ void LanguageDictionaryOverlayHandler::OnCustomDictionaryChanged(

remove_words.AppendString(word);

}

- web_ui()->CallJavascriptFunction("EditDictionaryOverlay.updateWords",

- add_words, remove_words);

+ web_ui()->CallJavascriptFunctionUnsafe("EditDictionaryOverlay.updateWords",

+ add_words, remove_words);

}

void LanguageDictionaryOverlayHandler::ResetDictionaryWords() {

@@ -103,8 +103,8 @@ void LanguageDictionaryOverlayHandler::ResetDictionaryWords() {

for (const std::string& word : dictionary_->GetWords()) {

list_value.AppendString(word);

}

- web_ui()->CallJavascriptFunction("EditDictionaryOverlay.setWordList",

- list_value);

+ web_ui()->CallJavascriptFunctionUnsafe("EditDictionaryOverlay.setWordList",

+ list_value);

}

void LanguageDictionaryOverlayHandler::RefreshWords(