chrome/browser/ui/webui/options/cookies_view_handler.cc - Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/cookies_view_handler.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/content_settings_handler.cc ('k') | chrome/browser/ui/webui/options/core_options_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/cookies_view_handler.cc

diff --git a/chrome/browser/ui/webui/options/cookies_view_handler.cc b/chrome/browser/ui/webui/options/cookies_view_handler.cc

index 6d57ff982690c6cf729164b65d4b82c0ca7f97d2..0d2fb42c761dbca622dedafe79af2c43af2888a8 100644

--- a/chrome/browser/ui/webui/options/cookies_view_handler.cc

+++ b/chrome/browser/ui/webui/options/cookies_view_handler.cc

@@ -156,7 +156,7 @@ void CookiesViewHandler::TreeNodesAdded(ui::TreeModel* model,

args.AppendString(model_util_->GetTreeNodeId(parent_node));

args.AppendInteger(start);

args.Append(std::move(children));

- web_ui()->CallJavascriptFunction("CookiesView.onTreeItemAdded", args);

+ web_ui()->CallJavascriptFunctionUnsafe("CookiesView.onTreeItemAdded", args);

}

void CookiesViewHandler::TreeNodesRemoved(ui::TreeModel* model,

@@ -176,7 +176,7 @@ void CookiesViewHandler::TreeNodesRemoved(ui::TreeModel* model,

args.AppendString(model_util_->GetTreeNodeId(tree_model->AsNode(parent)));

args.AppendInteger(start);

args.AppendInteger(count);

- web_ui()->CallJavascriptFunction("CookiesView.onTreeItemRemoved", args);

+ web_ui()->CallJavascriptFunctionUnsafe("CookiesView.onTreeItemRemoved", args);

}

void CookiesViewHandler::TreeModelBeginBatch(CookiesTreeModel* model) {

@@ -277,7 +277,7 @@ void CookiesViewHandler::SendChildren(const CookieTreeNode* parent) {

args.AppendString(model_util_->GetTreeNodeId(parent));

args.Append(std::move(children));

- web_ui()->CallJavascriptFunction("CookiesView.loadChildren", args);

+ web_ui()->CallJavascriptFunctionUnsafe("CookiesView.loadChildren", args);

}

void CookiesViewHandler::ReloadCookies(const base::ListValue* args) {