chrome/browser/chromeos/login/ui/webui_login_view.cc - Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/ui/webui_login_view.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/lock/webui_screen_locker.cc ('k') | chrome/browser/printing/print_preview_pdf_generated_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/ui/webui_login_view.cc

diff --git a/chrome/browser/chromeos/login/ui/webui_login_view.cc b/chrome/browser/chromeos/login/ui/webui_login_view.cc

index d4b7772230c3b311794e60c6fa760cf6a4ff587d..fda501d359fb080cf553505c55409085cef6056e 100644

--- a/chrome/browser/chromeos/login/ui/webui_login_view.cc

+++ b/chrome/browser/chromeos/login/ui/webui_login_view.cc

@@ -264,8 +264,8 @@ bool WebUILoginView::AcceleratorPressed(

content::WebUI* web_ui = GetWebUI();

if (web_ui) {

base::StringValue accel_name(entry->second);

- web_ui->CallJavascriptFunction("cr.ui.Oobe.handleAccelerator",

- accel_name);

+ web_ui->CallJavascriptFunctionUnsafe("cr.ui.Oobe.handleAccelerator",

+ accel_name);

}

return true;

@@ -421,7 +421,7 @@ void WebUILoginView::HandleKeyboardEvent(content::WebContents* source,

if (event.type == blink::WebInputEvent::KeyDown) {

content::WebUI* web_ui = GetWebUI();

if (web_ui)

- web_ui->CallJavascriptFunction("cr.ui.Oobe.clearErrors");

+ web_ui->CallJavascriptFunctionUnsafe("cr.ui.Oobe.clearErrors");

}