Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

content/public/browser/web_ui_message_handler.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_UI_MESSAGE_HANDLER_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_UI_MESSAGE_HANDLER_H_
 
 #include <vector>
 
 #include "base/gtest_prod_util.h"
@@ skipping 70 matching lines @@
   // the renderer.  This is asynchronous; there's no way to get the result
   // of the call, and should be thought of more like sending a message to
   // the page.
   // All function names in WebUI must consist of only ASCII characters.
   // These functions will crash if JavaScript is not currently allowed.
   template <typename... Values>
   void CallJavascriptFunction(const std::string& function_name,
                               const Values&... values) {
     CHECK(IsJavascriptAllowed()) << "Cannot CallJavascriptFunction before "
                                     "explicitly allowing JavaScript.";
-    web_ui()->CallJavascriptFunction(function_name, values...);
+    web_ui()->CallJavascriptFunctionUnsafe(function_name, values...);

[Charlie Reis, 2016/05/23 20:26:00]

Maybe put a comment here saying that the check above makes this call safe, just
to close the loop?

[tommycli, 2016/06/03 17:52:44]

Done.

   }
 
   // Returns the attached WebUI for this handler.
   WebUI* web_ui() const { return web_ui_; }
 
   // Sets the attached WebUI - exposed to subclasses for testing purposes.
   void set_web_ui(WebUI* web_ui) { web_ui_ = web_ui; }
 
  private:
   // Provide external classes access to web_ui(), set_web_ui(), and
   // RenderViewReused.
   friend class WebUIImpl;
   friend class ::WebUIBrowserTest;
 
   // Called when a RenderView is reused to display a page (i.e. reload).
   void RenderViewReused();
 
   // TODO(dbeam): disallow JavaScript when a renderer process crashes.
   // http://crbug.com/610450
 
   // True if the page is for JavaScript calls from this handler.
   bool javascript_allowed_;
 
   WebUI* web_ui_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_UI_MESSAGE_HANDLER_H_