chrome/browser/ui/webui/chromeos/login/inline_login_handler_chromeos.cc - Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/login/inline_login_handler_chromeos.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/eula_screen_handler.cc ('k') | chrome/browser/ui/webui/chromeos/login/kiosk_app_menu_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chromeos/login/inline_login_handler_chromeos.cc

diff --git a/chrome/browser/ui/webui/chromeos/login/inline_login_handler_chromeos.cc b/chrome/browser/ui/webui/chromeos/login/inline_login_handler_chromeos.cc

index 809c7f1e19ee67d5cc1f2bd7cb7ca97763078507..1d6d739dbb905fbef65228bd9203defdc05e0a77 100644

--- a/chrome/browser/ui/webui/chromeos/login/inline_login_handler_chromeos.cc

+++ b/chrome/browser/ui/webui/chromeos/login/inline_login_handler_chromeos.cc

@@ -43,7 +43,7 @@ class InlineLoginHandlerChromeOS::InlineLoginUIOAuth2Delegate

// might trigger a permission dialog and if this dialog does not close,

// a DCHECK would be triggered because attempting to activate a window

// while there is a modal dialog.

- web_ui_->CallJavascriptFunction("inline.login.closeDialog");

+ web_ui_->CallJavascriptFunctionUnsafe("inline.login.closeDialog");

Profile* profile = Profile::FromWebUI(web_ui_);

ProfileOAuth2TokenService* token_service =

@@ -53,7 +53,8 @@ class InlineLoginHandlerChromeOS::InlineLoginUIOAuth2Delegate

void OnOAuth2TokensFetchFailed() override {

LOG(ERROR) << "Failed to fetch oauth2 token with inline login.";

- web_ui_->CallJavascriptFunction("inline.login.handleOAuth2TokenFailure");

+ web_ui_->CallJavascriptFunctionUnsafe(

+ "inline.login.handleOAuth2TokenFailure");

}

private: