chrome/browser/ui/webui/chromeos/login/base_screen_handler.h - Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/login/base_screen_handler.h

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc ('k') | chrome/browser/ui/webui/chromeos/login/base_screen_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chromeos/login/base_screen_handler.h

diff --git a/chrome/browser/ui/webui/chromeos/login/base_screen_handler.h b/chrome/browser/ui/webui/chromeos/login/base_screen_handler.h

index d632b1806f200a6b4bbc949d440b74e8271517dc..613aa00e1e097a81711f14f037029f7aee5effb5 100644

--- a/chrome/browser/ui/webui/chromeos/login/base_screen_handler.h

+++ b/chrome/browser/ui/webui/chromeos/login/base_screen_handler.h

@@ -87,15 +87,15 @@ class BaseScreenHandler : public content::WebUIMessageHandler,

template<typename A1>

void CallJS(const std::string& method, const A1& arg1) {

- web_ui()->CallJavascriptFunction(FullMethodPath(method),

- ::login::MakeValue(arg1));

+ web_ui()->CallJavascriptFunctionUnsafe(FullMethodPath(method),

+ ::login::MakeValue(arg1));

}

template<typename A1, typename A2>

void CallJS(const std::string& method, const A1& arg1, const A2& arg2) {

- web_ui()->CallJavascriptFunction(FullMethodPath(method),

- ::login::MakeValue(arg1),

- ::login::MakeValue(arg2));

+ web_ui()->CallJavascriptFunctionUnsafe(FullMethodPath(method),

+ ::login::MakeValue(arg1),

+ ::login::MakeValue(arg2));

}

template<typename A1, typename A2, typename A3>

@@ -103,10 +103,9 @@ class BaseScreenHandler : public content::WebUIMessageHandler,

const A1& arg1,

const A2& arg2,

const A3& arg3) {

- web_ui()->CallJavascriptFunction(FullMethodPath(method),

- ::login::MakeValue(arg1),

- ::login::MakeValue(arg2),

- ::login::MakeValue(arg3));

+ web_ui()->CallJavascriptFunctionUnsafe(

+ FullMethodPath(method), ::login::MakeValue(arg1),

+ ::login::MakeValue(arg2), ::login::MakeValue(arg3));

}

template<typename A1, typename A2, typename A3, typename A4>

@@ -115,11 +114,10 @@ class BaseScreenHandler : public content::WebUIMessageHandler,