chrome/browser/ui/webui/chromeos/login/base_screen_handler.cc - Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/login/base_screen_handler.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/base_screen_handler.h ('k') | chrome/browser/ui/webui/chromeos/login/enable_debugging_screen_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chromeos/login/base_screen_handler.cc

diff --git a/chrome/browser/ui/webui/chromeos/login/base_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/base_screen_handler.cc

index 66038a801a235731667f40cc899f6a58b8205d9d..7586953c4361572750b9eefe468cdd3ee7127f9a 100644

--- a/chrome/browser/ui/webui/chromeos/login/base_screen_handler.cc

+++ b/chrome/browser/ui/webui/chromeos/login/base_screen_handler.cc

@@ -69,7 +69,7 @@ void BaseScreenHandler::GetAdditionalParameters(base::DictionaryValue* dict) {

}

void BaseScreenHandler::CallJS(const std::string& method) {

- web_ui()->CallJavascriptFunction(FullMethodPath(method));

+ web_ui()->CallJavascriptFunctionUnsafe(FullMethodPath(method));

}

void BaseScreenHandler::ShowScreen(OobeScreen screen) {

@@ -84,7 +84,8 @@ void BaseScreenHandler::ShowScreenWithData(OobeScreen screen,

screen_params.SetString("id", GetOobeScreenName(screen));

if (data)

screen_params.SetWithoutPathExpansion("data", data->DeepCopy());

- web_ui()->CallJavascriptFunction("cr.ui.Oobe.showScreen", screen_params);

+ web_ui()->CallJavascriptFunctionUnsafe("cr.ui.Oobe.showScreen",

+ screen_params);

}

OobeScreen BaseScreenHandler::GetCurrentScreen() const {