Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: chrome/browser/ui/webui/version_handler.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/version_handler.cc
diff --git a/chrome/browser/ui/webui/version_handler.cc b/chrome/browser/ui/webui/version_handler.cc
index d97890fc0f89d2ab2a3b8ffe78b8cb5eaff1382a..7259e930e86882d37c505990f5c15dfb763efe35 100644
--- a/chrome/browser/ui/webui/version_handler.cc
+++ b/chrome/browser/ui/webui/version_handler.cc
@@ -87,8 +87,8 @@ void VersionHandler::HandleRequestVersionInfo(const base::ListValue* args) {
base::Owned(profile_path_buffer)));
// Respond with the variations info immediately.
- web_ui()->CallJavascriptFunction(version_ui::kReturnVariationInfo,
- *version_ui::GetVariationsList());
+ web_ui()->CallJavascriptFunctionUnsafe(version_ui::kReturnVariationInfo,
+ *version_ui::GetVariationsList());
}
void VersionHandler::OnGotFilePaths(base::string16* executable_path_data,
@@ -97,8 +97,8 @@ void VersionHandler::OnGotFilePaths(base::string16* executable_path_data,
base::StringValue exec_path(*executable_path_data);
base::StringValue profile_path(*profile_path_data);
- web_ui()->CallJavascriptFunction(version_ui::kReturnFilePaths, exec_path,
- profile_path);
+ web_ui()->CallJavascriptFunctionUnsafe(version_ui::kReturnFilePaths,
+ exec_path, profile_path);
}
#if defined(ENABLE_PLUGINS)
@@ -122,6 +122,6 @@ void VersionHandler::OnGotPlugins(
}
base::StringValue arg(flash_version);
- web_ui()->CallJavascriptFunction(version_ui::kReturnFlashVersion, arg);
+ web_ui()->CallJavascriptFunctionUnsafe(version_ui::kReturnFlashVersion, arg);
}
#endif // defined(ENABLE_PLUGINS)
« no previous file with comments | « chrome/browser/ui/webui/user_actions/user_actions_ui_handler.cc ('k') | chrome/browser/ui/webui/version_handler_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698