chrome/browser/ui/webui/signin/inline_login_handler.cc - Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/inline_login_handler.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/quota_internals/quota_internals_handler.cc ('k') | chrome/browser/ui/webui/signin/inline_login_handler_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/signin/inline_login_handler.cc

diff --git a/chrome/browser/ui/webui/signin/inline_login_handler.cc b/chrome/browser/ui/webui/signin/inline_login_handler.cc

index 8836779240e5d400e04f4d37ecb41d43fa9a3992..8fea1e3e1922aa7311aa1c91ef2ebd00f127af33 100644

--- a/chrome/browser/ui/webui/signin/inline_login_handler.cc

+++ b/chrome/browser/ui/webui/signin/inline_login_handler.cc

@@ -231,7 +231,8 @@ void InlineLoginHandler::ContinueHandleInitializeMessage() {

SetExtraInitParams(params);

- web_ui()->CallJavascriptFunction("inline.login.loadAuthExtension", params);

+ web_ui()->CallJavascriptFunctionUnsafe("inline.login.loadAuthExtension",

+ params);

}

void InlineLoginHandler::HandleCompleteLoginMessage(

@@ -269,7 +270,7 @@ void InlineLoginHandler::HandleSwitchToFullTabMessage(

ui::PAGE_TRANSITION_AUTO_TOPLEVEL);

chrome::Navigate(&params);

- web_ui()->CallJavascriptFunction("inline.login.closeDialog");

+ web_ui()->CallJavascriptFunctionUnsafe("inline.login.closeDialog");

}

void InlineLoginHandler::HandleNavigationButtonClicked(