Delete unused code for exclusive access permission prompting.

Delete unused code for exclusive access permission prompting.

On all platforms and flag configurations (except Android, which is not
covered in this CL), we no longer prompt for fullscreen / mouse lock
permission. Therefore, all of the prompting infrastructure is dead code
and can now be safely deleted. This change should not have any
observable effect.

BUG=610900
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b6adb5143ab0cc79a64c64a42f965bbc595ab14c
Cr-Commit-Position: refs/heads/master@{#398504}

[Matt Giuca, 2016-05-24 07:14:58]

Description was changed from

==========
Delete unused code for exclusive access permission prompting.

On all platforms and flag configurations (except Android, which is not
covered in this CL), we no longer prompt for fullscreen / mouse lock
permission. Therefore, all of the prompting infrastructure is dead code
and can now be safely deleted. This change should not have any
observable effect.

BUG=610900
==========

to

==========
Delete unused code for exclusive access permission prompting.

On all platforms and flag configurations (except Android, which is not
covered in this CL), we no longer prompt for fullscreen / mouse lock
permission. Therefore, all of the prompting infrastructure is dead code
and can now be safely deleted. This change should not have any
observable effect.

BUG=610900
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Matt Giuca, 2016-05-31 03:22:39]

Patchset #4 (id:60001) has been deleted

[Matt Giuca, 2016-05-31 03:24:01]

mgiuca@chromium.org changed reviewers:
+ dbeam@chromium.org, scheib@chromium.org

[Matt Giuca, 2016-05-31 03:24:02]

dbeam@chromium.org: Please review changes in c/b/resources/options and
c/b/ui/webui/options.

scheib@chromium.org: Please review changes in c/b/ui/exclusive_access.

[Matt Giuca, 2016-05-31 03:24:54]

After this, there's no going back... no more fullscreen / mouse lock permission
prompting or global settings on any platform.

[scheib, 2016-05-31 18:20:24]

exclusive_access/fullscreen_controller_state_test.h has Allow/Deny concepts
still that can be removed (OK in a follow up change).

https://codereview.chromium.org/2004353002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/options/content_settings.html (right):

https://codereview.chromium.org/2004353002/diff/80001/chrome/browser/resource...
chrome/browser/resources/options/content_settings.html:640: <!-- Mouse Lock
filter -->
Can even more of this HTML be trimmed, since content settings are completely
unused now?

[Matt Giuca, 2016-06-01 00:54:29]

https://codereview.chromium.org/2004353002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/options/content_settings.html (right):

https://codereview.chromium.org/2004353002/diff/80001/chrome/browser/resource...
chrome/browser/resources/options/content_settings.html:640: <!-- Mouse Lock
filter -->
On 2016/05/31 18:20:24, scheib wrote:
> Can even more of this HTML be trimmed, since content settings are completely
> unused now?

Sadly, they are still used. https://crbug.com/591896

[scheib, 2016-06-01 01:01:03]

https://codereview.chromium.org/2004353002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/options/content_settings.html (right):

https://codereview.chromium.org/2004353002/diff/80001/chrome/browser/resource...
chrome/browser/resources/options/content_settings.html:640: <!-- Mouse Lock
filter -->
On 2016/06/01 00:54:29, Matt Giuca wrote:
> On 2016/05/31 18:20:24, scheib wrote:
> > Can even more of this HTML be trimmed, since content settings are completely
> > unused now?
> 
> Sadly, they are still used. https://crbug.com/591896

Ah, thanks. Please update the issue(or blockers) with specifically what is
remaining and add HTML comment here referencing this issue.

[Matt Giuca, 2016-06-01 01:11:03]

https://codereview.chromium.org/2004353002/diff/80001/chrome/browser/resource...
File chrome/browser/resources/options/content_settings.html (right):

https://codereview.chromium.org/2004353002/diff/80001/chrome/browser/resource...
chrome/browser/resources/options/content_settings.html:640: <!-- Mouse Lock
filter -->
On 2016/06/01 01:01:03, scheib wrote:
> On 2016/06/01 00:54:29, Matt Giuca wrote:
> > On 2016/05/31 18:20:24, scheib wrote:
> > > Can even more of this HTML be trimmed, since content settings are
completely
> > > unused now?
> > 
> > Sadly, they are still used. https://crbug.com/591896
> 
> Ah, thanks. Please update the issue(or blockers) with specifically what is
> remaining and add HTML comment here referencing this issue.

Done.

[Dan Beam, 2016-06-01 22:03:26]

lgtm

[scheib, 2016-06-01 22:05:05]

Elsewhere mgiuca informed me that we can't remove the accept/deny from the
fullscreen state tests as the methods are still used.

LGTM

[Matt Giuca, 2016-06-02 00:30:57]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2016-06-02 00:32:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004353002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2004353002/100001

[commit-bot: I haz the power, 2016-06-02 00:58:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-02 00:58:56]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Matt Giuca, 2016-06-06 04:35:24]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2016-06-06 04:35:24]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org,
dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2004353002/#ps120001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-06-06 04:35:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004353002/120001

[commit-bot: I haz the power, 2016-06-06 04:50:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 04:50:04]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Matt Giuca, 2016-06-06 04:53:16]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2016-06-06 04:53:17]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org,
dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2004353002/#ps140001
(title: "Fix unit_tests compile (remove some obsolete testing).")

[commit-bot: I haz the power, 2016-06-06 04:53:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004353002/140001

[commit-bot: I haz the power, 2016-06-06 05:07:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-06 05:07:42]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Matt Giuca, 2016-06-07 05:42:53]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-07 05:43:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004353002/160001

[Matt Giuca, 2016-06-07 05:43:43]

scheib: Sorry, I forgot to get the tests working. Maybe can you take a quick
look at the delta from PS6 to 8? (Can remove a lot of logic from the tests.)

[commit-bot: I haz the power, 2016-06-07 05:45:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 05:45:07]

Dry run: Try jobs failed on following builders:
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[Matt Giuca, 2016-06-07 06:51:39]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-07 06:52:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004353002/200001

[commit-bot: I haz the power, 2016-06-07 07:13:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-07 07:13:22]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[scheib, 2016-06-07 16:14:56]

Test changes LGTM, with one bit of confusion on my part:

https://codereview.chromium.org/2004353002/diff/180001/chrome/browser/ui/excl...
File
chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc
(right):

https://codereview.chromium.org/2004353002/diff/180001/chrome/browser/ui/excl...
chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc:402:
DISABLED_MouseLockThenFullscreen) {
This diff section is a touch confusing. It seems you truncated
DISABLED_EscapingMouseLockAndFullscreen, but the end of it sends ESC to exit
both modes and that part might as well remain?

Except for the meta point: all these tests have been disabled for so long. ;(
The flakiness of actually causing our windows to transition was frustrating, and
why the fullscreen state tests were made. We've significantly changed how the
bots run tests now though. I suppose we could try re-enabling these, or we can
just call it futile and remove them all.

[Matt Giuca, 2016-06-08 01:45:43]

https://codereview.chromium.org/2004353002/diff/180001/chrome/browser/ui/excl...
File
chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc
(right):

https://codereview.chromium.org/2004353002/diff/180001/chrome/browser/ui/excl...
chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc:402:
DISABLED_MouseLockThenFullscreen) {
On 2016/06/07 16:14:56, scheib wrote:
> This diff section is a touch confusing. It seems you truncated
> DISABLED_EscapingMouseLockAndFullscreen, but the end of it sends ESC to exit
> both modes and that part might as well remain?

I guess you're talking about the previous test (not sure why this comment is
here).

Well the test used to be:
1. Request lock.
2. Escape.
3. Request lock again.
4. Accept lock.
5. Escape.

I'm chopping out steps 3--5 (or equivalently, steps 2--4). The last thing this
test does press escape and test that it's not locked. There's no need to do the
second pass because now we've removed acceptance, the second pass would be the
same as the first pass.

> 
> Except for the meta point: all these tests have been disabled for so long. ;(
> The flakiness of actually causing our windows to transition was frustrating,
and
> why the fullscreen state tests were made. We've significantly changed how the
> bots run tests now though. I suppose we could try re-enabling these, or we can
> just call it futile and remove them all.

Yes :'(

I want to have a go at enabling this after deleting all the code that can be
deleted. Then there's a better chance of it being non-flaky.

I enabled it briefly yesterday to test but a lot was broken. But I made sure I'm
not introducing new breakage here (which is why I feel justified updating these
disabled tests despite that they aren't being run).

[Matt Giuca, 2016-06-08 01:45:50]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2016-06-08 01:45:51]

The patchset sent to the CQ was uploaded after l-g-t-m from dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2004353002/#ps200001
(title: "Rebase.")

[commit-bot: I haz the power, 2016-06-08 01:46:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004353002/200001

[scheib, 2016-06-08 01:49:22]

https://codereview.chromium.org/2004353002/diff/180001/chrome/browser/ui/excl...
File
chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc
(right):

https://codereview.chromium.org/2004353002/diff/180001/chrome/browser/ui/excl...
chrome/browser/ui/exclusive_access/fullscreen_controller_interactive_browsertest.cc:402:
DISABLED_MouseLockThenFullscreen) {
On 2016/06/08 01:45:43, Matt Giuca wrote:
> On 2016/06/07 16:14:56, scheib wrote:
> > This diff section is a touch confusing. It seems you truncated
> > DISABLED_EscapingMouseLockAndFullscreen, but the end of it sends ESC to exit
> > both modes and that part might as well remain?
> 
> I guess you're talking about the previous test (not sure why this comment is
> here).
> 
> Well the test used to be:
> 1. Request lock.
> 2. Escape.
> 3. Request lock again.
> 4. Accept lock.
> 5. Escape.
> 
> I'm chopping out steps 3--5 (or equivalently, steps 2--4). The last thing this
> test does press escape and test that it's not locked. There's no need to do
the
> second pass because now we've removed acceptance, the second pass would be the
> same as the first pass.
> 
> > 
> > Except for the meta point: all these tests have been disabled for so long.
;(
> > The flakiness of actually causing our windows to transition was frustrating,
> and
> > why the fullscreen state tests were made. We've significantly changed how
the
> > bots run tests now though. I suppose we could try re-enabling these, or we
can
> > just call it futile and remove them all.
> 
> Yes :'(
> 
> I want to have a go at enabling this after deleting all the code that can be
> deleted. Then there's a better chance of it being non-flaky.
> 
> I enabled it briefly yesterday to test but a lot was broken. But I made sure
I'm
> not introducing new breakage here (which is why I feel justified updating
these
> disabled tests despite that they aren't being run).

Thanks, easier to understand with that summary.

[commit-bot: I haz the power, 2016-06-08 02:26:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 02:26:56]

Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Matt Giuca, 2016-06-08 07:47:30]

On 2016/06/08 02:26:56, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

This CL is essentially trying to do two separate things and I've had a lot of
trouble passing tests on both of them. Sorry, Dan, but I'm going to split out
the content settings part (causing the latest round of 81 test failures) into a
separate CL: https://codereview.chromium.org/2045163002, which I should've done
in the first place. (I won't mail it out until tests pass.)

[Matt Giuca, 2016-06-08 07:47:38]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2016-06-08 07:47:38]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org,
dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2004353002/#ps220001
(title: "Remove changes to content settings UI (spun out to CL 2045163002).")

[commit-bot: I haz the power, 2016-06-08 07:47:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004353002/220001

[Matt Giuca, 2016-06-08 07:48:53]

Description was changed from

==========
Delete unused code for exclusive access permission prompting.

On all platforms and flag configurations (except Android, which is not
covered in this CL), we no longer prompt for fullscreen / mouse lock
permission. Therefore, all of the prompting infrastructure is dead code
and can now be safely deleted. This change should not have any
observable effect.

BUG=610900
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Delete unused code for exclusive access permission prompting.

On all platforms and flag configurations (except Android, which is not
covered in this CL), we no longer prompt for fullscreen / mouse lock
permission. Therefore, all of the prompting infrastructure is dead code
and can now be safely deleted. This change should not have any
observable effect.

BUG=610900
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[Matt Giuca, 2016-06-08 07:48:53]

mgiuca@chromium.org changed reviewers:
- dbeam@chromium.org

[commit-bot: I haz the power, 2016-06-08 08:41:49]

Description was changed from

==========
Delete unused code for exclusive access permission prompting.

On all platforms and flag configurations (except Android, which is not
covered in this CL), we no longer prompt for fullscreen / mouse lock
permission. Therefore, all of the prompting infrastructure is dead code
and can now be safely deleted. This change should not have any
observable effect.

BUG=610900
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Delete unused code for exclusive access permission prompting.

On all platforms and flag configurations (except Android, which is not
covered in this CL), we no longer prompt for fullscreen / mouse lock
permission. Therefore, all of the prompting infrastructure is dead code
and can now be safely deleted. This change should not have any
observable effect.

BUG=610900
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-06-08 08:41:51]

Committed patchset #11 (id:220001)

[commit-bot: I haz the power, 2016-06-08 08:44:38]

Description was changed from

==========
Delete unused code for exclusive access permission prompting.

On all platforms and flag configurations (except Android, which is not
covered in this CL), we no longer prompt for fullscreen / mouse lock
permission. Therefore, all of the prompting infrastructure is dead code
and can now be safely deleted. This change should not have any
observable effect.

BUG=610900
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
Delete unused code for exclusive access permission prompting.

On all platforms and flag configurations (except Android, which is not
covered in this CL), we no longer prompt for fullscreen / mouse lock
permission. Therefore, all of the prompting infrastructure is dead code
and can now be safely deleted. This change should not have any
observable effect.

BUG=610900
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/b6adb5143ab0cc79a64c64a42f965bbc595ab14c
Cr-Commit-Position: refs/heads/master@{#398504}
==========

[commit-bot: I haz the power, 2016-06-08 08:44:40]

Patchset 11 (id:??) landed as
https://crrev.com/b6adb5143ab0cc79a64c64a42f965bbc595ab14c
Cr-Commit-Position: refs/heads/master@{#398504}