Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5144)

Unified Diff: chrome/browser/ui/webui/inspect_ui.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/webui/identity_internals_ui.cc ('k') | chrome/browser/ui/webui/instant_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/inspect_ui.cc
diff --git a/chrome/browser/ui/webui/inspect_ui.cc b/chrome/browser/ui/webui/inspect_ui.cc
index 25a1e7d5991a21cc7bc0f9c8df653472787cfb16..3fdb6146da58cbdffd40a2811913d634b197b194 100644
--- a/chrome/browser/ui/webui/inspect_ui.cc
+++ b/chrome/browser/ui/webui/inspect_ui.cc
@@ -434,19 +434,19 @@ content::WebUIDataSource* InspectUI::CreateInspectUIHTMLSource() {
}
void InspectUI::UpdateDiscoverUsbDevicesEnabled() {
- web_ui()->CallJavascriptFunction(
+ web_ui()->CallJavascriptFunctionUnsafe(
"updateDiscoverUsbDevicesEnabled",
*GetPrefValue(prefs::kDevToolsDiscoverUsbDevicesEnabled));
}
void InspectUI::UpdatePortForwardingEnabled() {
- web_ui()->CallJavascriptFunction(
+ web_ui()->CallJavascriptFunctionUnsafe(
"updatePortForwardingEnabled",
*GetPrefValue(prefs::kDevToolsPortForwardingEnabled));
}
void InspectUI::UpdatePortForwardingConfig() {
- web_ui()->CallJavascriptFunction(
+ web_ui()->CallJavascriptFunctionUnsafe(
"updatePortForwardingConfig",
*GetPrefValue(prefs::kDevToolsPortForwardingConfig));
}
@@ -510,9 +510,8 @@ DevToolsTargetImpl* InspectUI::FindTarget(
void InspectUI::PopulateTargets(const std::string& source,
const base::ListValue& targets) {
- web_ui()->CallJavascriptFunction("populateTargets",
- base::StringValue(source),
- targets);
+ web_ui()->CallJavascriptFunctionUnsafe("populateTargets",
+ base::StringValue(source), targets);
}
void InspectUI::ForceUpdateIfNeeded(const std::string& source_id,
@@ -527,9 +526,9 @@ void InspectUI::ForceUpdateIfNeeded(const std::string& source_id,
}
void InspectUI::PopulatePortStatus(const base::Value& status) {
- web_ui()->CallJavascriptFunction("populatePortStatus", status);
+ web_ui()->CallJavascriptFunctionUnsafe("populatePortStatus", status);
}
void InspectUI::ShowIncognitoWarning() {
- web_ui()->CallJavascriptFunction("showIncognitoWarning");
+ web_ui()->CallJavascriptFunctionUnsafe("showIncognitoWarning");
}
« no previous file with comments | « chrome/browser/ui/webui/identity_internals_ui.cc ('k') | chrome/browser/ui/webui/instant_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698