Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2138)

Unified Diff: content/public/browser/web_ui_message_handler.h

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/web_ui.h ('k') | content/public/test/test_web_ui.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/web_ui_message_handler.h
diff --git a/content/public/browser/web_ui_message_handler.h b/content/public/browser/web_ui_message_handler.h
index ed0117931f59bc8cc8db1b135a2c606aea0c2015..d7647d12797806c321f497226a91a786933accfc 100644
--- a/content/public/browser/web_ui_message_handler.h
+++ b/content/public/browser/web_ui_message_handler.h
@@ -88,7 +88,9 @@ class CONTENT_EXPORT WebUIMessageHandler {
const Values&... values) {
CHECK(IsJavascriptAllowed()) << "Cannot CallJavascriptFunction before "
"explicitly allowing JavaScript.";
- web_ui()->CallJavascriptFunction(function_name, values...);
+
+ // The CHECK above makes this call safe.
+ web_ui()->CallJavascriptFunctionUnsafe(function_name, values...);
}
// Returns the attached WebUI for this handler.
« no previous file with comments | « content/public/browser/web_ui.h ('k') | content/public/test/test_web_ui.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698