chrome/browser/ui/webui/policy_ui_handler.cc - Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/policy_ui_handler.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/policy_material_design_ui.cc ('k') | chrome/browser/ui/webui/popular_sites_internals_message_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/policy_ui_handler.cc

diff --git a/chrome/browser/ui/webui/policy_ui_handler.cc b/chrome/browser/ui/webui/policy_ui_handler.cc

index b26b7d94d6f967197ca2affa5f732bd71250b891..57dc0fb551fc3b8ddb5e5d71ad829423da51e22d 100644

--- a/chrome/browser/ui/webui/policy_ui_handler.cc

+++ b/chrome/browser/ui/webui/policy_ui_handler.cc

@@ -614,7 +614,7 @@ void PolicyUIHandler::SendPolicyNames() const {

names.Set("extensionPolicyNames", extension_policy_names);

#endif // defined(ENABLE_EXTENSIONS)

- web_ui()->CallJavascriptFunction("policy.Page.setPolicyNames", names);

+ web_ui()->CallJavascriptFunctionUnsafe("policy.Page.setPolicyNames", names);

}

void PolicyUIHandler::SendPolicyValues() const {

@@ -647,7 +647,8 @@ void PolicyUIHandler::SendPolicyValues() const {

}

all_policies.Set("extensionPolicies", extension_values);

#endif

- web_ui()->CallJavascriptFunction("policy.Page.setPolicyValues", all_policies);

+ web_ui()->CallJavascriptFunctionUnsafe("policy.Page.setPolicyValues",

+ all_policies);

}

void PolicyUIHandler::GetPolicyValues(const policy::PolicyMap& map,

@@ -713,7 +714,7 @@ void PolicyUIHandler::SendStatus() const {

if (!user_status->empty())

status.Set("user", user_status.release());

- web_ui()->CallJavascriptFunction("policy.Page.setStatus", status);

+ web_ui()->CallJavascriptFunctionUnsafe("policy.Page.setStatus", status);

}

void PolicyUIHandler::HandleInitialized(const base::ListValue* args) {

@@ -742,7 +743,7 @@ void PolicyUIHandler::HandleReloadPolicies(const base::ListValue* args) {

}

void PolicyUIHandler::OnRefreshPoliciesDone() const {

- web_ui()->CallJavascriptFunction("policy.Page.reloadPoliciesDone");

+ web_ui()->CallJavascriptFunctionUnsafe("policy.Page.reloadPoliciesDone");

}

policy::PolicyService* PolicyUIHandler::GetPolicyService() const {