chrome/browser/ui/webui/supervised_user_internals_message_handler.cc - Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/supervised_user_internals_message_handler.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/snippets_internals_message_handler.cc ('k') | chrome/browser/ui/webui/sync_file_system_internals/dump_database_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/supervised_user_internals_message_handler.cc

diff --git a/chrome/browser/ui/webui/supervised_user_internals_message_handler.cc b/chrome/browser/ui/webui/supervised_user_internals_message_handler.cc

index 26c6b1c4514e64603abbfd6b5e3b4b18228527af..a62967e6d4b32b5c5f1da5acb0acd48f25fafde4 100644

--- a/chrome/browser/ui/webui/supervised_user_internals_message_handler.cc

+++ b/chrome/browser/ui/webui/supervised_user_internals_message_handler.cc

@@ -284,7 +284,7 @@ void SupervisedUserInternalsMessageHandler::SendBasicInfo() {

base::DictionaryValue result;

result.Set("sections", std::move(section_list));

- web_ui()->CallJavascriptFunction(

+ web_ui()->CallJavascriptFunctionUnsafe(

"chrome.supervised_user_internals.receiveBasicInfo", result);

// Trigger retrieval of the user settings

@@ -297,7 +297,7 @@ void SupervisedUserInternalsMessageHandler::SendBasicInfo() {

void SupervisedUserInternalsMessageHandler::SendSupervisedUserSettings(

const base::DictionaryValue* settings) {

- web_ui()->CallJavascriptFunction(

+ web_ui()->CallJavascriptFunctionUnsafe(

"chrome.supervised_user_internals.receiveUserSettings",

*(settings ? settings : base::Value::CreateNullValue().get()));

}

@@ -320,7 +320,7 @@ void SupervisedUserInternalsMessageHandler::OnTryURLResult(

result.SetBoolean("manual", reason == supervised_user_error_page::MANUAL &&

behavior == SupervisedUserURLFilter::ALLOW);

result.SetString("whitelists", whitelists_str);

- web_ui()->CallJavascriptFunction(

+ web_ui()->CallJavascriptFunctionUnsafe(

"chrome.supervised_user_internals.receiveTryURLResult", result);

}

@@ -334,6 +334,6 @@ void SupervisedUserInternalsMessageHandler::OnURLChecked(

result.SetString("url", url.possibly_invalid_spec());

result.SetString("result", FilteringBehaviorToString(behavior, uncertain));

result.SetString("reason", FilteringBehaviorReasonToString(reason));

- web_ui()->CallJavascriptFunction(

+ web_ui()->CallJavascriptFunctionUnsafe(

"chrome.supervised_user_internals.receiveFilteringResult", result);

}