chrome/browser/ui/webui/options/startup_pages_handler.cc - Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/startup_pages_handler.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/search_engine_manager_handler.cc ('k') | chrome/browser/ui/webui/options/supervised_user_create_confirm_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/startup_pages_handler.cc

diff --git a/chrome/browser/ui/webui/options/startup_pages_handler.cc b/chrome/browser/ui/webui/options/startup_pages_handler.cc

index 6a8e61b5ab61097a1c17cf316940f7978ade76c6..a06fa42f1eecee4e24fcf469935f6a30cb9b6bc5 100644

--- a/chrome/browser/ui/webui/options/startup_pages_handler.cc

+++ b/chrome/browser/ui/webui/options/startup_pages_handler.cc

@@ -130,8 +130,8 @@ void StartupPagesHandler::OnModelChanged() {

startup_pages.Append(entry);

}

- web_ui()->CallJavascriptFunction("StartupOverlay.updateStartupPages",

- startup_pages);

+ web_ui()->CallJavascriptFunctionUnsafe("StartupOverlay.updateStartupPages",

+ startup_pages);

}

void StartupPagesHandler::OnItemsChanged(int start, int length) {

@@ -262,7 +262,7 @@ void StartupPagesHandler::OnResultChanged(bool default_match_changed) {

const AutocompleteResult& result = autocomplete_controller_->result();

base::ListValue suggestions;

OptionsUI::ProcessAutocompleteSuggestions(result, &suggestions);

- web_ui()->CallJavascriptFunction(

+ web_ui()->CallJavascriptFunctionUnsafe(

"StartupOverlay.updateAutocompleteSuggestions", suggestions);

}