Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: chrome/browser/ui/webui/invalidations_message_handler.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/invalidations_message_handler.cc
diff --git a/chrome/browser/ui/webui/invalidations_message_handler.cc b/chrome/browser/ui/webui/invalidations_message_handler.cc
index 372c789230ceb5cf42da034e5babfa4ac602037f..42e15e8724b0e38bcb1b713846f936e7c465d77e 100644
--- a/chrome/browser/ui/webui/invalidations_message_handler.cc
+++ b/chrome/browser/ui/webui/invalidations_message_handler.cc
@@ -78,15 +78,15 @@ void InvalidationsMessageHandler::OnRegistrationChange(
it != registered_handlers.end(); ++it) {
list_of_handlers.AppendString(*it);
}
- web_ui()->CallJavascriptFunction("chrome.invalidations.updateHandlers",
- list_of_handlers);
+ web_ui()->CallJavascriptFunctionUnsafe("chrome.invalidations.updateHandlers",
+ list_of_handlers);
}
void InvalidationsMessageHandler::OnStateChange(
const syncer::InvalidatorState& new_state,
const base::Time& last_changed_timestamp) {
std::string state(syncer::InvalidatorStateToString(new_state));
- web_ui()->CallJavascriptFunction(
+ web_ui()->CallJavascriptFunctionUnsafe(
"chrome.invalidations.updateInvalidatorState", base::StringValue(state),
base::FundamentalValue(last_changed_timestamp.ToJsTime()));
}
@@ -104,9 +104,9 @@ void InvalidationsMessageHandler::OnUpdateIds(
dic->SetInteger("totalCount", it->second);
list_of_objects.Append(dic.release());
}
- web_ui()->CallJavascriptFunction("chrome.invalidations.updateIds",
- base::StringValue(handler_name),
- list_of_objects);
+ web_ui()->CallJavascriptFunctionUnsafe("chrome.invalidations.updateIds",
+ base::StringValue(handler_name),
+ list_of_objects);
}
void InvalidationsMessageHandler::OnDebugMessage(
const base::DictionaryValue& details) {}
@@ -115,12 +115,12 @@ void InvalidationsMessageHandler::OnInvalidation(
const syncer::ObjectIdInvalidationMap& new_invalidations) {
std::unique_ptr<base::ListValue> invalidations_list =
new_invalidations.ToValue();
- web_ui()->CallJavascriptFunction("chrome.invalidations.logInvalidations",
- *invalidations_list);
+ web_ui()->CallJavascriptFunctionUnsafe(
+ "chrome.invalidations.logInvalidations", *invalidations_list);
}
void InvalidationsMessageHandler::OnDetailedStatus(
const base::DictionaryValue& network_details) {
- web_ui()->CallJavascriptFunction("chrome.invalidations.updateDetailedStatus",
- network_details);
+ web_ui()->CallJavascriptFunctionUnsafe(
+ "chrome.invalidations.updateDetailedStatus", network_details);
}
« no previous file with comments | « chrome/browser/ui/webui/instant_ui.cc ('k') | chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698