Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

content/public/browser/web_ui.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_WEB_UI_H_
 #define CONTENT_PUBLIC_BROWSER_WEB_UI_H_
 
 #include <vector>
 
 #include "base/callback.h"
@@ skipping 77 matching lines @@
   // This is only needed if an embedder overrides handling of a WebUIMessage and
   // then later wants to undo that, or to route it to a different WebUI object.
   virtual void ProcessWebUIMessage(const GURL& source_url,
                                    const std::string& message,
                                    const base::ListValue& args) = 0;
 
   // Returns true if this WebUI can currently call JavaScript.
   virtual bool CanCallJavascript() = 0;
 
   // Calling these functions directly is discouraged. It's generally preferred
-  // to call WebUIMessageHandler::CallJavascriptFunction, as that has
+  // to call WebUIMessageHandler::CallJavascriptFunctionUnsafe, as that has

[Charlie Reis, 2016/05/23 20:26:00]

This should still be CallJavascriptFunction.

[tommycli, 2016/06/03 17:52:44]

Done.

   // lifecycle controls to prevent calling JavaScript before the page is ready.
   //
   // Call a Javascript function by sending its name and arguments down to
   // the renderer.  This is asynchronous; there's no way to get the result
   // of the call, and should be thought of more like sending a message to
   // the page.
   //
   // All function names in WebUI must consist of only ASCII characters.
   // There are variants for calls with more arguments.
-  virtual void CallJavascriptFunction(const std::string& function_name) = 0;
-  virtual void CallJavascriptFunction(const std::string& function_name,
-                                      const base::Value& arg) = 0;
-  virtual void CallJavascriptFunction(const std::string& function_name,
-                                      const base::Value& arg1,
-                                      const base::Value& arg2) = 0;
-  virtual void CallJavascriptFunction(const std::string& function_name,
-                                      const base::Value& arg1,
-                                      const base::Value& arg2,
-                                      const base::Value& arg3) = 0;
-  virtual void CallJavascriptFunction(const std::string& function_name,
-                                      const base::Value& arg1,
-                                      const base::Value& arg2,
-                                      const base::Value& arg3,
-                                      const base::Value& arg4) = 0;
-  virtual void CallJavascriptFunction(
+  virtual void CallJavascriptFunctionUnsafe(
+      const std::string& function_name) = 0;
+  virtual void CallJavascriptFunctionUnsafe(const std::string& function_name,
+                                            const base::Value& arg) = 0;
+  virtual void CallJavascriptFunctionUnsafe(const std::string& function_name,
+                                            const base::Value& arg1,
+                                            const base::Value& arg2) = 0;
+  virtual void CallJavascriptFunctionUnsafe(const std::string& function_name,
+                                            const base::Value& arg1,
+                                            const base::Value& arg2,
+                                            const base::Value& arg3) = 0;
+  virtual void CallJavascriptFunctionUnsafe(const std::string& function_name,
+                                            const base::Value& arg1,
+                                            const base::Value& arg2,
+                                            const base::Value& arg3,
+                                            const base::Value& arg4) = 0;
+  virtual void CallJavascriptFunctionUnsafe(
       const std::string& function_name,
       const std::vector<const base::Value*>& args) = 0;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_WEB_UI_H_