Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6984)

Unified Diff: chrome/browser/ui/webui/options/core_options_handler.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/core_options_handler.cc
diff --git a/chrome/browser/ui/webui/options/core_options_handler.cc b/chrome/browser/ui/webui/options/core_options_handler.cc
index aa3ce4addd6187757ee939834ac829659ac37e3a..dbe9310aef8e4cb813110708f8da7a098fff2ac4 100644
--- a/chrome/browser/ui/webui/options/core_options_handler.cc
+++ b/chrome/browser/ui/webui/options/core_options_handler.cc
@@ -362,7 +362,7 @@ void CoreOptionsHandler::DispatchPrefChangeNotification(
for (PreferenceCallbackMap::const_iterator iter = range.first;
iter != range.second; ++iter) {
const std::string& callback_function = iter->second;
- web_ui()->CallJavascriptFunction(callback_function, result_value);
+ web_ui()->CallJavascriptFunctionUnsafe(callback_function, result_value);
}
}
@@ -471,8 +471,8 @@ void CoreOptionsHandler::HandleFetchPrefs(const base::ListValue* args) {
result_value.Set(pref_name, FetchPref(pref_name));
}
- web_ui()->CallJavascriptFunction(base::UTF16ToASCII(callback_function),
- result_value);
+ web_ui()->CallJavascriptFunctionUnsafe(base::UTF16ToASCII(callback_function),
+ result_value);
}
void CoreOptionsHandler::HandleObservePrefs(const base::ListValue* args) {
@@ -648,14 +648,14 @@ void CoreOptionsHandler::HandleDisableExtension(const base::ListValue* args) {
void CoreOptionsHandler::UpdateClearPluginLSOData() {
base::FundamentalValue enabled(
plugin_status_pref_setter_.IsClearPluginLSODataEnabled());
- web_ui()->CallJavascriptFunction(
+ web_ui()->CallJavascriptFunctionUnsafe(
"options.OptionsPage.setClearPluginLSODataEnabled", enabled);
}
void CoreOptionsHandler::UpdatePepperFlashSettingsEnabled() {
base::FundamentalValue enabled(
plugin_status_pref_setter_.IsPepperFlashSettingsEnabled());
- web_ui()->CallJavascriptFunction(
+ web_ui()->CallJavascriptFunctionUnsafe(
"options.OptionsPage.setPepperFlashSettingsEnabled", enabled);
}
« no previous file with comments | « chrome/browser/ui/webui/options/cookies_view_handler.cc ('k') | chrome/browser/ui/webui/options/create_profile_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698