chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc - Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/options/chromeos/display_overscan_handler.cc ('k') | chrome/browser/ui/webui/options/chromeos/pointer_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc

diff --git a/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc b/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc

index 1a97d9561f416dff0fa01c471e73fa6134f52c1c..0429a44a16ddeb27a9bf28a935bd411c2630c0dd 100644

--- a/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc

+++ b/chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc

@@ -155,7 +155,7 @@ void KeyboardHandler::InitializePage() {

chromeos::switches::kHasChromeOSDiamondKey);

const base::FundamentalValue show_diamond_key_options(has_diamond_key);

- web_ui()->CallJavascriptFunction(

+ web_ui()->CallJavascriptFunctionUnsafe(

"options.KeyboardOverlay.showDiamondKeyOptions",

show_diamond_key_options);

@@ -180,9 +180,8 @@ void KeyboardHandler::HandleShowKeyboardShortcuts(const base::ListValue* args) {

void KeyboardHandler::UpdateCapsLockOptions() const {

const base::FundamentalValue show_caps_lock_options(HasExternalKeyboard());

- web_ui()->CallJavascriptFunction(

- "options.KeyboardOverlay.showCapsLockOptions",

- show_caps_lock_options);

+ web_ui()->CallJavascriptFunctionUnsafe(

+ "options.KeyboardOverlay.showCapsLockOptions", show_caps_lock_options);

}

} // namespace options