Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2045163002: Remove (already-hidden) global fullscreen / mouselock settings. (Closed)

Created:
4 years, 6 months ago by Matt Giuca
Modified:
4 years, 6 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, michaelpg+watch-options_chromium.org, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@tommycli-rename-calljavascriptfunction
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove (already-hidden) global fullscreen / mouselock settings. This UI was already hidden. This just removes the HTML code for those radio buttons, as well as the unused code for showing these buttons, and the strings. BUG=610900 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/e6da50af4580380fbf35d7d425178dc3dc853263 Cr-Commit-Position: refs/heads/master@{#398757}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -72 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -9 lines 0 comments Download
M chrome/browser/resources/options/content_settings.html View 1 chunk +6 lines, -34 lines 0 comments Download
M chrome/browser/resources/options/content_settings.js View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/options/content_settings_handler.cc View 3 chunks +6 lines, -16 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 15 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045163002/1
4 years, 6 months ago (2016-06-08 07:33:00 UTC) #3
Matt Giuca
Hi Dan, This is spun out of https://codereview.chromium.org/2004353002/. Terribly sorry to do this after you ...
4 years, 6 months ago (2016-06-08 08:26:40 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-08 08:28:18 UTC) #7
Matt Giuca
On 2016/06/08 08:28:18, commit-bot: I haz the power wrote: > Dry run: This issue passed ...
4 years, 6 months ago (2016-06-08 08:29:06 UTC) #8
Dan Beam
lgtm
4 years, 6 months ago (2016-06-08 18:36:31 UTC) #9
Matt Giuca
Thanks!
4 years, 6 months ago (2016-06-09 01:11:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2045163002/1
4 years, 6 months ago (2016-06-09 01:11:59 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 01:16:13 UTC) #13
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 01:19:09 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e6da50af4580380fbf35d7d425178dc3dc853263
Cr-Commit-Position: refs/heads/master@{#398757}

Powered by Google App Engine
This is Rietveld 408576698