chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc - Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc

Issue 1995113002: Rename WebUI::CallJavascriptFunction to WebUI::CallJavascriptFunctionUnsafe (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/signin/signin_create_profile_handler.cc ('k') | chrome/browser/ui/webui/signin/sync_confirmation_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc

diff --git a/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc b/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc

index c7eb3a4b86be19be15d3b03f3d046d840202b12c..e5d20c6bc42bef76a18b306bcc1ec52540a511b9 100644

--- a/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc

+++ b/chrome/browser/ui/webui/signin/signin_supervised_user_import_handler.cc

@@ -190,10 +190,9 @@ void SigninSupervisedUserImportHandler::LoadCustodianProfileCallback(

void SigninSupervisedUserImportHandler::RejectCallback(

const base::string16& error) {

- web_ui()->CallJavascriptFunction("cr.webUIResponse",

- base::StringValue(webui_callback_id_),

- base::FundamentalValue(false),

- base::StringValue(error));

+ web_ui()->CallJavascriptFunctionUnsafe(

+ "cr.webUIResponse", base::StringValue(webui_callback_id_),

+ base::FundamentalValue(false), base::StringValue(error));

webui_callback_id_.clear();

}

@@ -267,10 +266,9 @@ void SigninSupervisedUserImportHandler::SendExistingSupervisedUsers(

}

// Resolve callback with response.

- web_ui()->CallJavascriptFunction("cr.webUIResponse",

- base::StringValue(webui_callback_id_),

- base::FundamentalValue(true),

- supervised_users);

+ web_ui()->CallJavascriptFunctionUnsafe(

+ "cr.webUIResponse", base::StringValue(webui_callback_id_),

+ base::FundamentalValue(true), supervised_users);

webui_callback_id_.clear();

}