Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 109433013: Move geometric types to a separate, more lightweight target. (Closed)

Created:
7 years ago by Ben Goodger (Google)
Modified:
7 years ago
Reviewers:
tfarina, sky
CC:
chromium-reviews, sadrul, viettrungluu+watch_chromium.org, rjkroege, amit, sievers+watch_chromium.org, ben+aura_chromium.org, ben+mojo_chromium.org, danakj+watch_chromium.org, miu+watch_chromium.org, extensions-reviews_chromium.org, jam, abarth-chromium, joi+watch-content_chromium.org, darin-cc_chromium.org, chromium-apps-reviews_chromium.org, android-webview-reviews_chromium.org, cc-bugs_chromium.org, dcaiafa+watch_chromium.org, wez+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, sanjeevr, feature-media-reviews_chromium.org, jbauman+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, kalyank, piman+watch_chromium.org, sergeyu+watch_chromium.org, darin (slow to review), jamiewalch+watch_chromium.org, hclam+watch_chromium.org, ozone-reviews_chromium.org, Ian Vollick, tfarina, garykac+watch_chromium.org, Aaron Boodman, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, ben+ash_chromium.org
Visibility:
Public.

Description

Move geometric types to a separate, more lightweight target. R=sky@chromium.org http://crbug.com/327489 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241649

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : . #

Total comments: 3

Patch Set 5 : . #

Patch Set 6 : . #

Patch Set 7 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+438 lines, -6427 lines) Patch
M android_webview/native/webview_native.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M ash/ash.gyp View 1 2 3 4 5 3 chunks +3 lines, -0 lines 0 comments Download
M cc/cc.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M cc/cc_tests.gyp View 1 2 3 4 5 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser_extensions.gypi View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_browser_ui_views.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 2 3 4 5 6 4 chunks +4 lines, -0 lines 0 comments Download
M components/autofill.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M components/web_contents_delegate_android.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/content_app.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/content_child.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/content_ppapi_plugin.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M content/content_shell.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 4 5 8 chunks +8 lines, -0 lines 0 comments Download
M device/bluetooth/bluetooth.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/command_buffer_service.gypi View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M gpu/gles2_conform_support/gles2_conform_support.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gpu/gpu.gyp View 1 2 3 4 5 5 chunks +5 lines, -0 lines 0 comments Download
M media/cast/cast.gyp View 1 2 3 2 chunks +2 lines, -0 lines 0 comments Download
M media/cast/test/utility/utility.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M media/cast/video_sender/codecs/vp8/vp8_encoder.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M media/media.gyp View 1 2 3 4 5 4 chunks +4 lines, -0 lines 0 comments Download
M mojo/mojo.gyp View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M mojo/mojo_examples.gypi View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M mojo/mojo_services.gypi View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download
M printing/printing.gyp View 1 2 3 4 5 2 chunks +2 lines, -0 lines 0 comments Download
M remoting/remoting.gyp View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download
M tools/memory_watcher/memory_watcher.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M tools/set_default_handler/set_default_handler.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/accessibility/accessibility.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/app_list/app_list.gyp View 1 2 3 4 5 6 2 chunks +2 lines, -0 lines 0 comments Download
M ui/aura/aura.gyp View 1 2 3 4 5 5 chunks +6 lines, -0 lines 1 comment Download
M ui/compositor/compositor.gyp View 1 2 3 4 5 3 chunks +3 lines, -0 lines 0 comments Download
M ui/events/events.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
D ui/gfx/box_f.h View 1 2 1 chunk +2 lines, -155 lines 0 comments Download
D ui/gfx/box_f.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D ui/gfx/box_unittest.cc View 1 chunk +0 lines, -176 lines 0 comments Download
A + ui/gfx/geometry/box_f.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
A + ui/gfx/geometry/box_f.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/geometry/box_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/geometry/insets.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/gfx/geometry/insets.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/geometry/insets_base.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/geometry/insets_f.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/gfx/geometry/insets_f.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/geometry/insets_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/geometry/matrix3_f.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/gfx/geometry/matrix3_f.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/geometry/matrix3_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/geometry/point.h View 1 2 2 chunks +6 lines, -6 lines 0 comments Download
A + ui/gfx/geometry/point.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/geometry/point3_f.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
A + ui/gfx/geometry/point3_f.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/geometry/point3_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
A + ui/gfx/geometry/point_base.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/geometry/point_conversions.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
A + ui/gfx/geometry/point_conversions.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/gfx/geometry/point_f.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
A + ui/gfx/geometry/point_f.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/geometry/point_unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
A + ui/gfx/geometry/quad_f.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
A + ui/gfx/geometry/quad_f.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/geometry/quad_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
A + ui/gfx/geometry/rect.h View 1 2 3 2 chunks +8 lines, -8 lines 0 comments Download
A + ui/gfx/geometry/rect.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/geometry/rect_base.h View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/geometry/rect_base_impl.h View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
A + ui/gfx/geometry/rect_conversions.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
A + ui/gfx/geometry/rect_conversions.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/gfx/geometry/rect_f.h View 1 2 2 chunks +7 lines, -7 lines 0 comments Download
A + ui/gfx/geometry/rect_f.cc View 1 chunk +4 lines, -4 lines 0 comments Download
A + ui/gfx/geometry/rect_unittest.cc View 1 2 3 2 chunks +8 lines, -19 lines 0 comments Download
A + ui/gfx/geometry/safe_integer_conversions.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/geometry/safe_integer_conversions_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/geometry/size.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
A + ui/gfx/geometry/size.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/geometry/size_base.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/geometry/size_conversions.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
A + ui/gfx/geometry/size_conversions.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/gfx/geometry/size_f.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/gfx/geometry/size_f.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/geometry/size_unittest.cc View 1 chunk +4 lines, -5 lines 0 comments Download
A + ui/gfx/geometry/vector2d.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/gfx/geometry/vector2d.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/geometry/vector2d_conversions.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
A + ui/gfx/geometry/vector2d_conversions.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/gfx/geometry/vector2d_f.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/gfx/geometry/vector2d_f.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/geometry/vector2d_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
A + ui/gfx/geometry/vector3d_f.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + ui/gfx/geometry/vector3d_f.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ui/gfx/geometry/vector3d_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/gfx/gfx.gyp View 1 2 3 4 5 8 chunks +83 lines, -44 lines 0 comments Download
D ui/gfx/insets.h View 1 2 1 chunk +3 lines, -48 lines 0 comments Download
D ui/gfx/insets.cc View 1 chunk +0 lines, -38 lines 0 comments Download
D ui/gfx/insets_base.h View 1 chunk +0 lines, -80 lines 0 comments Download
D ui/gfx/insets_f.h View 1 2 1 chunk +3 lines, -29 lines 0 comments Download
D ui/gfx/insets_f.cc View 1 chunk +0 lines, -25 lines 0 comments Download
D ui/gfx/insets_unittest.cc View 1 chunk +0 lines, -66 lines 0 comments Download
D ui/gfx/matrix3_f.h View 1 2 1 chunk +3 lines, -104 lines 0 comments Download
D ui/gfx/matrix3_f.cc View 1 chunk +0 lines, -237 lines 0 comments Download
D ui/gfx/matrix3_unittest.cc View 1 chunk +0 lines, -148 lines 0 comments Download
D ui/gfx/point.h View 1 2 1 chunk +3 lines, -86 lines 0 comments Download
D ui/gfx/point.cc View 1 chunk +0 lines, -54 lines 0 comments Download
D ui/gfx/point3_f.h View 1 2 1 chunk +3 lines, -116 lines 0 comments Download
D ui/gfx/point3_f.cc View 1 chunk +0 lines, -40 lines 0 comments Download
D ui/gfx/point3_unittest.cc View 1 chunk +0 lines, -70 lines 0 comments Download
D ui/gfx/point_base.h View 1 chunk +0 lines, -87 lines 0 comments Download
D ui/gfx/point_conversions.h View 1 2 1 chunk +3 lines, -20 lines 0 comments Download
D ui/gfx/point_conversions.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D ui/gfx/point_f.h View 1 2 1 chunk +3 lines, -71 lines 0 comments Download
D ui/gfx/point_f.cc View 1 chunk +0 lines, -24 lines 0 comments Download
D ui/gfx/point_unittest.cc View 1 chunk +0 lines, -174 lines 0 comments Download
D ui/gfx/quad_f.h View 1 2 1 chunk +3 lines, -105 lines 0 comments Download
D ui/gfx/quad_f.cc View 1 chunk +0 lines, -127 lines 0 comments Download
D ui/gfx/quad_unittest.cc View 1 chunk +0 lines, -360 lines 0 comments Download
M ui/gfx/rect.h View 1 2 3 1 chunk +3 lines, -141 lines 0 comments Download
D ui/gfx/rect.cc View 1 2 3 1 chunk +0 lines, -110 lines 0 comments Download
D ui/gfx/rect_base.h View 1 2 3 1 chunk +0 lines, -174 lines 0 comments Download
D ui/gfx/rect_base_impl.h View 1 2 3 1 chunk +0 lines, -355 lines 0 comments Download
D ui/gfx/rect_conversions.h View 1 2 1 chunk +3 lines, -32 lines 0 comments Download
D ui/gfx/rect_conversions.cc View 1 chunk +0 lines, -82 lines 0 comments Download
D ui/gfx/rect_f.h View 1 2 1 chunk +3 lines, -109 lines 0 comments Download
D ui/gfx/rect_f.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D ui/gfx/rect_unittest.cc View 1 2 3 1 chunk +0 lines, -936 lines 0 comments Download
D ui/gfx/safe_integer_conversions.h View 1 2 1 chunk +3 lines, -50 lines 0 comments Download
D ui/gfx/safe_integer_conversions_unittest.cc View 1 chunk +0 lines, -109 lines 0 comments Download
D ui/gfx/size.h View 1 2 1 chunk +3 lines, -63 lines 0 comments Download
D ui/gfx/size.cc View 1 chunk +0 lines, -46 lines 0 comments Download
D ui/gfx/size_base.h View 1 chunk +0 lines, -69 lines 0 comments Download
D ui/gfx/size_conversions.h View 1 2 1 chunk +3 lines, -20 lines 0 comments Download
D ui/gfx/size_conversions.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D ui/gfx/size_f.h View 1 2 1 chunk +3 lines, -50 lines 0 comments Download
D ui/gfx/size_f.cc View 1 chunk +0 lines, -23 lines 0 comments Download
D ui/gfx/size_unittest.cc View 1 chunk +0 lines, -128 lines 0 comments Download
A ui/gfx/skrect_conversion_unittest.cc View 1 1 chunk +26 lines, -0 lines 0 comments Download
D ui/gfx/vector2d.h View 1 2 1 chunk +3 lines, -87 lines 0 comments Download
D ui/gfx/vector2d.cc View 1 chunk +0 lines, -39 lines 0 comments Download
D ui/gfx/vector2d_conversions.h View 1 2 1 chunk +3 lines, -20 lines 0 comments Download
D ui/gfx/vector2d_conversions.cc View 1 chunk +0 lines, -30 lines 0 comments Download
D ui/gfx/vector2d_f.h View 1 2 1 chunk +3 lines, -108 lines 0 comments Download
D ui/gfx/vector2d_f.cc View 1 chunk +0 lines, -60 lines 0 comments Download
D ui/gfx/vector2d_unittest.cc View 1 chunk +0 lines, -250 lines 0 comments Download
D ui/gfx/vector3d_f.h View 1 2 1 chunk +3 lines, -120 lines 0 comments Download
D ui/gfx/vector3d_f.cc View 1 chunk +0 lines, -88 lines 0 comments Download
D ui/gfx/vector3d_unittest.cc View 1 chunk +0 lines, -264 lines 0 comments Download
M ui/gl/gl.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/keyboard/keyboard.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/message_center/message_center.gyp View 1 2 3 4 5 6 3 chunks +3 lines, -0 lines 0 comments Download
M ui/native_theme/native_theme.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/oak/oak.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/ozone/ozone.gyp View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M ui/snapshot/snapshot.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/surface/surface.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/ui.gyp View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M ui/ui_unittests.gyp View 1 4 chunks +3 lines, -11 lines 0 comments Download
M ui/v2/v2.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/views/controls/webview/webview.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/views.gyp View 1 2 3 4 5 6 7 chunks +7 lines, -0 lines 0 comments Download
M webkit/child/webkit_child.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/common/gpu/webkit_gpu.gyp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M webkit/common/webkit_common.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/glue/webkit_glue.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/renderer/compositor_bindings/compositor_bindings.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webkit/renderer/webkit_renderer.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M win8/delegate_execute/delegate_execute.gyp View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Ben Goodger (Google)
7 years ago (2013-12-12 00:00:20 UTC) #1
sky
Rubber stamp LGTM
7 years ago (2013-12-12 00:01:41 UTC) #2
tfarina
https://codereview.chromium.org/109433013/diff/60001/ui/aura/aura.gyp File ui/aura/aura.gyp (right): https://codereview.chromium.org/109433013/diff/60001/ui/aura/aura.gyp#newcode153 ui/aura/aura.gyp:153: '../resources/ui_resources.gyp:ui_test_pak', you had to add it back? https://codereview.chromium.org/109433013/diff/60001/ui/gfx/gfx.gyp File ...
7 years ago (2013-12-12 21:22:31 UTC) #3
tfarina
https://codereview.chromium.org/109433013/diff/60001/ui/aura/aura.gyp File ui/aura/aura.gyp (right): https://codereview.chromium.org/109433013/diff/60001/ui/aura/aura.gyp#newcode153 ui/aura/aura.gyp:153: '../resources/ui_resources.gyp:ui_test_pak', you had to add it back? https://codereview.chromium.org/109433013/diff/60001/ui/gfx/gfx.gyp File ...
7 years ago (2013-12-12 21:22:32 UTC) #4
Ben Goodger (Google)
Committed patchset #7 manually as r241649 (presubmit successful).
7 years ago (2013-12-18 21:01:50 UTC) #5
tfarina
https://codereview.chromium.org/109433013/diff/120001/ui/aura/aura.gyp File ui/aura/aura.gyp (right): https://codereview.chromium.org/109433013/diff/120001/ui/aura/aura.gyp#newcode155 ui/aura/aura.gyp:155: '../resources/ui_resources.gyp:ui_test_pak', Ben, why did you add this back?
7 years ago (2013-12-18 22:24:35 UTC) #6
Ben Goodger (Google)
7 years ago (2013-12-18 22:47:54 UTC) #7 
Oops this may have been a bad merge.

-Ben


On Wed, Dec 18, 2013 at 2:24 PM, <tfarina@chromium.org> wrote:

>
> https://codereview.chromium.org/109433013/diff/120001/ui/aura/aura.gyp
> File ui/aura/aura.gyp (right):
>
> https://codereview.chromium.org/109433013/diff/120001/ui/
> aura/aura.gyp#newcode155
> ui/aura/aura.gyp:155: '../resources/ui_resources.gyp:ui_test_pak',
> Ben, why did you add this back?
>
> https://codereview.chromium.org/109433013/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Powered by Google App Engine
This is Rietveld 408576698