Replace ASSERT with DCHECK in modules/

Replace ASSERT with DCHECK in modules/

This CL only affects instances of ASSERT() that have unary parameters
with no (in)equality checks.

BUG=596760
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2862963003
Cr-Commit-Position: refs/heads/master@{#470215}
Committed: https://chromium.googlesource.com/chromium/src/+/53082dc60af4f4f0586b86e1dc92bf6355b7af07

[pilgrim_google, 2017-05-05 17:45:42]

Description was changed from

==========
Replace ASSERT with DCHECK in modules/

This CL only affects instances of ASSERT() that have unary parameters
with no (in)equality checks.

BUG=596760
==========

to

==========
Replace ASSERT with DCHECK in modules/

This CL only affects instances of ASSERT() that have unary parameters
with no (in)equality checks.

BUG=596760
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[pilgrim_google, 2017-05-05 17:45:58]

pilgrim@chromium.org changed reviewers:
+ haraken@chromium.org, tkent@chromium.org

[pilgrim_google, 2017-05-05 17:46:07]

The CQ bit was checked by pilgrim@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-05 17:46:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 20:07:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-05 20:07:32]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[haraken, 2017-05-06 00:59:57]

LGTM

[tkent, 2017-05-07 22:57:53]

lgtm

https://codereview.chromium.org/2862963003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp
(right):

https://codereview.chromium.org/2862963003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/plugins/PluginOcclusionSupport.cpp:113:
DCHECK(false);  // We should have seen ro1 and ro2 by now.
This should be NOTREACHED().

[pilgrim_google, 2017-05-08 20:21:47]

The CQ bit was checked by pilgrim@chromium.org

[pilgrim_google, 2017-05-08 20:21:47]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2862963003/#ps20001
(title: "NOTREACHED instead of DCHECK(false)")

[commit-bot: I haz the power, 2017-05-08 20:22:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-09 04:40:06]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1494274907163790,
"parent_rev": "85edb5c8cb4d700870cff49f11d133be7c64d10a", "commit_rev":
"53082dc60af4f4f0586b86e1dc92bf6355b7af07"}

[commit-bot: I haz the power, 2017-05-09 04:40:14]

Description was changed from

==========
Replace ASSERT with DCHECK in modules/

This CL only affects instances of ASSERT() that have unary parameters
with no (in)equality checks.

BUG=596760
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Replace ASSERT with DCHECK in modules/

This CL only affects instances of ASSERT() that have unary parameters
with no (in)equality checks.

BUG=596760
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2862963003
Cr-Commit-Position: refs/heads/master@{#470215}
Committed:
https://chromium.googlesource.com/chromium/src/+/53082dc60af4f4f0586b86e1dc92...
==========

[commit-bot: I haz the power, 2017-05-09 04:40:16]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/53082dc60af4f4f0586b86e1dc92...