third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp - Issue 2862963003: Replace ASSERT with DCHECK in modules/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)

Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/encoding/TextDecoder.cpp ('k') | third_party/WebKit/Source/modules/netinfo/NavigatorNetworkInformation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp

diff --git a/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp b/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp

index f078654bf4ced475fa36c0bcdba70a9c60361c2c..384e7fbeafcf1315cdf2e3824f73ed85ba4acb17 100644

--- a/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp

+++ b/third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp

@@ -147,7 +147,7 @@ void NavigatorContentUtils::registerProtocolHandler(

return;

Document* document = navigator.GetFrame()->GetDocument();

- ASSERT(document);

+ DCHECK(document);

if (!VerifyCustomHandlerURL(*document, url, exception_state))

return;

@@ -195,7 +195,7 @@ String NavigatorContentUtils::isProtocolHandlerRegistered(

return declined;

Document* document = navigator.GetFrame()->GetDocument();

- ASSERT(document);

+ DCHECK(document);

if (document->IsContextDestroyed())

return declined;

@@ -220,7 +220,7 @@ void NavigatorContentUtils::unregisterProtocolHandler(

return;

Document* document = navigator.GetFrame()->GetDocument();

- ASSERT(document);

+ DCHECK(document);

if (!VerifyCustomHandlerURL(*document, url, exception_state))

return;