Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Unified Diff: third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)
Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp
diff --git a/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp b/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp
index d0f4b57be315bca61c832c045902f34b3024f8a4..eb7ddec8cbd0d9b48fea6842d77d78c8957fbc6e 100644
--- a/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp
+++ b/third_party/WebKit/Source/modules/netinfo/NetworkInformation.cpp
@@ -47,7 +47,7 @@ NetworkInformation* NetworkInformation::Create(ExecutionContext* context) {
}
NetworkInformation::~NetworkInformation() {
- ASSERT(!observing_);
+ DCHECK(!observing_);
}
String NetworkInformation::type() const {
@@ -69,7 +69,7 @@ double NetworkInformation::downlinkMax() const {
void NetworkInformation::ConnectionChange(WebConnectionType type,
double downlink_max_mbps) {
- ASSERT(GetExecutionContext()->IsContextThread());
+ DCHECK(GetExecutionContext()->IsContextThread());
// This can happen if the observer removes and then adds itself again
// during notification.
@@ -111,7 +111,7 @@ void NetworkInformation::RemovedEventListener(
void NetworkInformation::RemoveAllEventListeners() {
EventTargetWithInlineData::RemoveAllEventListeners();
- ASSERT(!HasEventListeners());
+ DCHECK(!HasEventListeners());
StopObserving();
}

Powered by Google App Engine
This is Rietveld 408576698