third_party/WebKit/Source/modules/webusb/USBAlternateInterface.cpp - Issue 2862963003: Replace ASSERT with DCHECK in modules/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webusb/USBAlternateInterface.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)

Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webusb/USBAlternateInterface.cpp

diff --git a/third_party/WebKit/Source/modules/webusb/USBAlternateInterface.cpp b/third_party/WebKit/Source/modules/webusb/USBAlternateInterface.cpp

index 8b6d8f79b373eabdb8c78cec1f7bff41f49780a1..9eac61f609a84ac562b00ea474cd33fa36d9d00f 100644

--- a/third_party/WebKit/Source/modules/webusb/USBAlternateInterface.cpp

+++ b/third_party/WebKit/Source/modules/webusb/USBAlternateInterface.cpp

@@ -32,7 +32,7 @@ USBAlternateInterface* USBAlternateInterface::Create(

USBAlternateInterface::USBAlternateInterface(const USBInterface* interface,

size_t alternate_index)

: interface_(interface), alternate_index_(alternate_index) {

- ASSERT(interface_);

+ DCHECK(interface_);

ASSERT(alternate_index_ < interface_->Info().alternates.size());

}