third_party/WebKit/Source/modules/webgl/WebGLActiveInfo.h - Issue 2862963003: Replace ASSERT with DCHECK in modules/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLActiveInfo.h

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)

Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webgl/WebGLActiveInfo.h

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLActiveInfo.h b/third_party/WebKit/Source/modules/webgl/WebGLActiveInfo.h

index c0e68f43ced413194102660fbcf78fe6bf99eeda..ca09106630064d44bb1dc0a714d16f0cca9fa444 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLActiveInfo.h

+++ b/third_party/WebKit/Source/modules/webgl/WebGLActiveInfo.h

@@ -48,9 +48,9 @@ class WebGLActiveInfo final : public GarbageCollectedFinalized<WebGLActiveInfo>,

private:

WebGLActiveInfo(const String& name, GLenum type, GLint size)

: name_(name), type_(type), size_(size) {

- ASSERT(name.length());

- ASSERT(type);

- ASSERT(size);

+ DCHECK(name.length());

+ DCHECK(type);

+ DCHECK(size);

}

String name_;

GLenum type_;