third_party/WebKit/Source/modules/webgl/WebGLObject.cpp - Issue 2862963003: Replace ASSERT with DCHECK in modules/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLObject.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)

Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webgl/WebGLObject.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLObject.cpp b/third_party/WebKit/Source/modules/webgl/WebGLObject.cpp

index b6abc8a4577481f2ea3964cc3b80300ae74c3173..8c84b431e4f8e33e6c1724f0a2f55c7da87dac2d 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLObject.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLObject.cpp

@@ -60,7 +60,7 @@ void WebGLObject::DeleteObject(gpu::gles2::GLES2Interface* gl) {

if (gl) {

DeleteObjectImpl(gl);

// Ensure the inherited class no longer claims to have a valid object

- ASSERT(!HasObject());

+ DCHECK(!HasObject());

}