Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(842)

Unified Diff: third_party/WebKit/Source/modules/crypto/CryptoResultImpl.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)
Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/crypto/CryptoResultImpl.cpp
diff --git a/third_party/WebKit/Source/modules/crypto/CryptoResultImpl.cpp b/third_party/WebKit/Source/modules/crypto/CryptoResultImpl.cpp
index 0396abe4bd228b4859fec3d56d0961716e4b2845..f1463f9b79a7bd3cbc8b9fa0dd16f0139fac86e4 100644
--- a/third_party/WebKit/Source/modules/crypto/CryptoResultImpl.cpp
+++ b/third_party/WebKit/Source/modules/crypto/CryptoResultImpl.cpp
@@ -64,7 +64,7 @@ static void RejectWithTypeError(const String& error_details,
class CryptoResultImpl::Resolver final : public ScriptPromiseResolver {
public:
static Resolver* Create(ScriptState* script_state, CryptoResultImpl* result) {
- ASSERT(script_state->ContextIsValid());
+ DCHECK(script_state->ContextIsValid());
Resolver* resolver = new Resolver(script_state, result);
resolver->SuspendIfNeeded();
resolver->KeepAliveWhilePending();
@@ -128,7 +128,7 @@ CryptoResultImpl::CryptoResultImpl(ScriptState* script_state)
}
CryptoResultImpl::~CryptoResultImpl() {
- ASSERT(!resolver_);
+ DCHECK(!resolver_);
}
DEFINE_TRACE(CryptoResultImpl) {
@@ -226,7 +226,7 @@ void CryptoResultImpl::CompleteWithKeyPair(const WebCryptoKey& public_key,
}
void CryptoResultImpl::Cancel() {
- ASSERT(cancel_);
+ DCHECK(cancel_);
cancel_->Cancel();
cancel_.Clear();
ClearResolver();

Powered by Google App Engine
This is Rietveld 408576698