Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: third_party/WebKit/Source/modules/webusb/USBDevice.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)
Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "modules/webusb/USBDevice.h" 5 #include "modules/webusb/USBDevice.h"
6 6
7 #include "bindings/core/v8/ScriptPromise.h" 7 #include "bindings/core/v8/ScriptPromise.h"
8 #include "bindings/core/v8/ScriptPromiseResolver.h" 8 #include "bindings/core/v8/ScriptPromiseResolver.h"
9 #include "bindings/core/v8/ToV8ForCore.h" 9 #include "bindings/core/v8/ToV8ForCore.h"
10 #include "core/dom/DOMArrayBuffer.h" 10 #include "core/dom/DOMArrayBuffer.h"
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
80 case UsbTransferStatus::BABBLE: 80 case UsbTransferStatus::BABBLE:
81 return "babble"; 81 return "babble";
82 default: 82 default:
83 NOTREACHED(); 83 NOTREACHED();
84 return ""; 84 return "";
85 } 85 }
86 } 86 }
87 87
88 Vector<uint8_t> ConvertBufferSource( 88 Vector<uint8_t> ConvertBufferSource(
89 const ArrayBufferOrArrayBufferView& buffer) { 89 const ArrayBufferOrArrayBufferView& buffer) {
90 ASSERT(!buffer.isNull()); 90 DCHECK(!buffer.isNull());
91 Vector<uint8_t> vector; 91 Vector<uint8_t> vector;
92 if (buffer.isArrayBuffer()) 92 if (buffer.isArrayBuffer())
93 vector.Append(static_cast<uint8_t*>(buffer.getAsArrayBuffer()->Data()), 93 vector.Append(static_cast<uint8_t*>(buffer.getAsArrayBuffer()->Data()),
94 buffer.getAsArrayBuffer()->ByteLength()); 94 buffer.getAsArrayBuffer()->ByteLength());
95 else 95 else
96 vector.Append(static_cast<uint8_t*>( 96 vector.Append(static_cast<uint8_t*>(
97 buffer.getAsArrayBufferView().View()->BaseAddress()), 97 buffer.getAsArrayBufferView().View()->BaseAddress()),
98 buffer.getAsArrayBufferView().View()->byteLength()); 98 buffer.getAsArrayBufferView().View()->byteLength());
99 return vector; 99 return vector;
100 } 100 }
(...skipping 824 matching lines...) Expand 10 before | Expand all | Expand 10 after
925 925
926 bool USBDevice::MarkRequestComplete(ScriptPromiseResolver* resolver) { 926 bool USBDevice::MarkRequestComplete(ScriptPromiseResolver* resolver) {
927 auto request_entry = device_requests_.find(resolver); 927 auto request_entry = device_requests_.find(resolver);
928 if (request_entry == device_requests_.end()) 928 if (request_entry == device_requests_.end())
929 return false; 929 return false;
930 device_requests_.erase(request_entry); 930 device_requests_.erase(request_entry);
931 return true; 931 return true;
932 } 932 }
933 933
934 } // namespace blink 934 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698