third_party/WebKit/Source/modules/webusb/USBDevice.cpp - Issue 2862963003: Replace ASSERT with DCHECK in modules/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webusb/USBDevice.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)

Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webusb/USBDevice.cpp

diff --git a/third_party/WebKit/Source/modules/webusb/USBDevice.cpp b/third_party/WebKit/Source/modules/webusb/USBDevice.cpp

index 63296201fdd938e8d3868985934a5e247c653a49..03bd0ff3592e2449b638811592d4278fe07b0d08 100644

--- a/third_party/WebKit/Source/modules/webusb/USBDevice.cpp

+++ b/third_party/WebKit/Source/modules/webusb/USBDevice.cpp

@@ -87,7 +87,7 @@ String ConvertTransferStatus(const UsbTransferStatus& status) {

Vector<uint8_t> ConvertBufferSource(

const ArrayBufferOrArrayBufferView& buffer) {

- ASSERT(!buffer.isNull());

+ DCHECK(!buffer.isNull());

Vector<uint8_t> vector;

if (buffer.isArrayBuffer())

vector.Append(static_cast<uint8_t*>(buffer.getAsArrayBuffer()->Data()),