third_party/WebKit/Source/modules/webusb/USBConfiguration.cpp - Issue 2862963003: Replace ASSERT with DCHECK in modules/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webusb/USBConfiguration.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)

Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/webusb/USBConfiguration.cpp

diff --git a/third_party/WebKit/Source/modules/webusb/USBConfiguration.cpp b/third_party/WebKit/Source/modules/webusb/USBConfiguration.cpp

index 96239557c7ec05523ee8503249f0e096d0c8b3cc..05ab6eb0965c7f63aa1f7188fa559fc06b915cb9 100644

--- a/third_party/WebKit/Source/modules/webusb/USBConfiguration.cpp

+++ b/third_party/WebKit/Source/modules/webusb/USBConfiguration.cpp

@@ -31,7 +31,7 @@ USBConfiguration* USBConfiguration::Create(const USBDevice* device,

USBConfiguration::USBConfiguration(const USBDevice* device,

size_t configuration_index)

: device_(device), configuration_index_(configuration_index) {

- ASSERT(device_);

+ DCHECK(device_);

ASSERT(configuration_index_ < device_->Info().configurations.size());

}