third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp - Issue 2862963003: Replace ASSERT with DCHECK in modules/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)

Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp

index a8c4118cd56b5ac67209c9ca57b1cd98656936db..5456aea1f7bd01409f959caacdcf1643e9cdc946 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp

@@ -155,7 +155,7 @@ ServiceWorker::ServiceWorker(ExecutionContext* execution_context,

: AbstractWorker(execution_context),

handle_(std::move(handle)),

was_stopped_(false) {

- ASSERT(handle_);

+ DCHECK(handle_);

handle_->ServiceWorker()->SetProxy(this);

}