third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp - Issue 2862963003: Replace ASSERT with DCHECK in modules/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)

Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/presentation/Presentation.cpp ('k') | third_party/WebKit/Source/modules/presentation/PresentationAvailabilityCallbacks.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp

diff --git a/third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp b/third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp

index 2f08e51f3ddf6d80c10d4544e6952fdc356be725..a6be63de12751baa4a3d45376cc82d86d735f8a2 100644

--- a/third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp

+++ b/third_party/WebKit/Source/modules/presentation/PresentationAvailability.cpp

@@ -54,7 +54,7 @@ PresentationAvailability::PresentationAvailability(

urls_(urls),

value_(value),

state_(State::kActive) {

- ASSERT(execution_context->IsDocument());

+ DCHECK(execution_context->IsDocument());

WebVector<WebURL> data(urls.size());

for (size_t i = 0; i < urls.size(); ++i)

data[i] = WebURL(urls[i]);