Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Unified Diff: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp

Issue 2862963003: Replace ASSERT with DCHECK in modules/ (Closed)
Patch Set: NOTREACHED instead of DCHECK(false) Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp
diff --git a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp
index 341149deffc7f1bca4f02ea86455f1f33e6ecb0d..c32e72dd149d7aca57bd8940712f17cc76c2a2ef 100644
--- a/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp
+++ b/third_party/WebKit/Source/modules/screen_orientation/ScreenOrientation.cpp
@@ -93,7 +93,7 @@ static WebScreenOrientationLockType StringToOrientationLock(
// static
ScreenOrientation* ScreenOrientation::Create(LocalFrame* frame) {
- ASSERT(frame);
+ DCHECK(frame);
// Check if the ScreenOrientationController is supported for the
// frame. It will not be for all LocalFrames, or the frame may
@@ -102,7 +102,7 @@ ScreenOrientation* ScreenOrientation::Create(LocalFrame* frame) {
return nullptr;
ScreenOrientation* orientation = new ScreenOrientation(frame);
- ASSERT(orientation->Controller());
+ DCHECK(orientation->Controller());
// FIXME: ideally, we would like to provide the ScreenOrientationController
// the case where it is not defined but for the moment, it is eagerly
// created when the LocalFrame is created so we shouldn't be in that

Powered by Google App Engine
This is Rietveld 408576698